From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 3D73B20248 for ; Mon, 18 Mar 2019 12:50:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726780AbfCRMuL (ORCPT ); Mon, 18 Mar 2019 08:50:11 -0400 Received: from siwi.pair.com ([209.68.5.199]:52695 "EHLO siwi.pair.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726612AbfCRMuL (ORCPT ); Mon, 18 Mar 2019 08:50:11 -0400 Received: from siwi.pair.com (localhost [127.0.0.1]) by siwi.pair.com (Postfix) with ESMTP id A75A03F409A; Mon, 18 Mar 2019 08:50:09 -0400 (EDT) Received: from [IPv6:2600:1700:840:e760:8c2:e809:e774:3a6d] (unknown [IPv6:2600:1700:840:e760:8c2:e809:e774:3a6d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by siwi.pair.com (Postfix) with ESMTPSA id 7939B3F4023; Mon, 18 Mar 2019 08:50:09 -0400 (EDT) Subject: Re: [PATCH 0/2] Randomize / timestamp trace2 targets To: Josh Steadmon , git@vger.kernel.org, =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= References: <366839dd-7470-bda0-d84e-4169842c7852@jeffhostetler.com> <20190315203836.GD47591@google.com> From: Jeff Hostetler Message-ID: Date: Mon, 18 Mar 2019 08:50:05 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:66.0) Gecko/20100101 Thunderbird/66.0 MIME-Version: 1.0 In-Reply-To: <20190315203836.GD47591@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 3/15/2019 4:38 PM, Josh Steadmon wrote: > On 2019.03.15 15:18, Jeff Hostetler wrote: >> >> >> On 3/13/2019 7:33 PM, Josh Steadmon wrote: >>> Persistently enabling trace2 output is difficult because it requires >>> specifying a full filename. This series teaches tr2_dst_get_trace_fd() >>> to randomize filenames when a directory or filename prefix are given as >>> targets in the GIT_TR2_* envvars. It also allows expansion of a >>> timestamp template string into the current UTC timestamp. >> >> >> Does the use of envvar cause issues? Or is it just the fixed absolute >> pathname? When I started this, I was trying to keep the GIT_TRACE >> model. >> >> As was briefly discussed in [1] I was thinking of adding a way to >> have a personal and/or system setting, but not a git config variable, >> that would let you setup tracing without relying on environment >> variables. >> >> It's something that I've been wanting to do, it just got buried by >> $DAYJOB stuff. I can try to bump it up if there's interest. >> >> Thanks >> Jeff >> >> [1] https://public-inbox.org/git/pull.108.v4.git.gitgitgadget@gmail.com/T/#mcce3b088aabc42e9867f8a9e09dd7dea5f9a773a > > Yeah in our case it's the fixed filename that's the issue. It's more > convenient for us to have lots of small files that are "finished" > relatively quickly, rather than one that is constantly appended to. > Ok. Great. So if you want to go ahead and do the "if it's a directory append the last component of the sid" thing, I'll wait for that and then add the envvar alternative being discussed in another fork of this thread. Thanks Jeff