From: Jeff Hostetler <git@jeffhostetler.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Dec 2023, #01; Sat, 9)
Date: Thu, 14 Dec 2023 10:19:19 -0500 [thread overview]
Message-ID: <e5295dbe-94d2-3186-5663-2466eba4bdde@jeffhostetler.com> (raw)
In-Reply-To: <xmqqa5qknnej.fsf@gitster.g>
On 12/8/23 9:02 PM, Junio C Hamano wrote:
> --------------------------------------------------
...
>
> * jc/diff-cached-fsmonitor-fix (2023-09-15) 3 commits
> - diff-lib: fix check_removed() when fsmonitor is active
> - Merge branch 'jc/fake-lstat' into jc/diff-cached-fsmonitor-fix
> - Merge branch 'js/diff-cached-fsmonitor-fix' into jc/diff-cached-fsmonitor-fix
> (this branch uses jc/fake-lstat.)
>
> The optimization based on fsmonitor in the "diff --cached"
> codepath is resurrected with the "fake-lstat" introduced earlier.
>
> It is unknown if the optimization is worth resurrecting, but in case...
> source: <xmqqr0n0h0tw.fsf@gitster.g>
>
> --------------------------------------------------
...
> * jc/fake-lstat (2023-09-15) 1 commit
> - cache: add fake_lstat()
> (this branch is used by jc/diff-cached-fsmonitor-fix.)
>
> A new helper to let us pretend that we called lstat() when we know
> our cache_entry is up-to-date via fsmonitor.
>
> Needs review.
> source: <xmqqcyykig1l.fsf@gitster.g>
>
>
I think these look good. And yes, it is better to insure that the
stat struct is always well-defined rather than sometimes uninitialized.
FWIW, in
f954c7b8ff3 (fsmonitor: never set CE_FSMONITOR_VALID on submodules,
2022-05-26)
we try to never set the CE_FSMONITOR_VALID bit on submodules (because
status on a submodule is much more than just an lstat check on the
submodule root directory and we always should recursively ask Git to
compute the submodule's status).
I haven't had time to investigate, but I wonder if the original
complaint on `diff-lib` was due to another code path that allowed
the CE_FSMONITOR_VALID bit to get set on a submodule entry.
Jeff
next prev parent reply other threads:[~2023-12-14 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 2:02 What's cooking in git.git (Dec 2023, #01; Sat, 9) Junio C Hamano
2023-12-12 1:32 ` Jeff King
2023-12-14 15:19 ` Jeff Hostetler [this message]
2023-12-14 16:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5295dbe-94d2-3186-5663-2466eba4bdde@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).