From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: Stefan Beller <sbeller@google.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Jonathan Tan <jonathantanmy@google.com>,
Jeff Hostetler <jeffhost@microsoft.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: Test failures on 'pu' branch
Date: Wed, 8 Nov 2017 22:34:49 +0000 [thread overview]
Message-ID: <e2d10701-2deb-4f03-f4ce-3da7d48effa3@ramsayjones.plus.com> (raw)
In-Reply-To: <CAGZ79kb3NpuWW=BpTjF_DrdVhXHh3d_8aF77Jdpi+8yTxtAbVw@mail.gmail.com>
On 08/11/17 20:36, Stefan Beller wrote:
> On Wed, Nov 8, 2017 at 12:28 PM, Ramsay Jones
> <ramsay@ramsayjones.plus.com> wrote:
>
>> t5300-pack-object.sh (Wstat: 256 Tests: 40 Failed: 2)
>
>> t5500-fetch-pack.sh (Wstat: 256 Tests: 355 Failed: 6)
>
> These are series
>
>> t5601-clone.sh (Wstat: 256 Tests: 102 Failed: 4)
>
> This one is a spurious test. I had that flake on me once in the last weeks, too.
> But upon investigation I could not reproduce.
> See https://public-inbox.org/git/xmqq376ipdpx.fsf@gitster.mtv.corp.google.com/
>
No, this is not related to that. In fact several tests start
working if I change the '--filter=blobs:limit=0' to instead
read '--filter=blob:limit=0' (ie. change blob_s_ to blob).
In fact t5601 now works with the following patch:
-- >8 --
diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh
index f18d9454a..0074690f7 100755
--- a/t/t5601-clone.sh
+++ b/t/t5601-clone.sh
@@ -630,7 +630,7 @@ partial_clone () {
test_config -C "$SERVER" uploadpack.allowfilter 1 &&
test_config -C "$SERVER" uploadpack.allowanysha1inwant 1 &&
- git clone --filter=blobs:limit=0 "$URL" client &&
+ git clone --filter=blob:limit=0 "$URL" client &&
git -C client fsck &&
@@ -651,7 +651,7 @@ test_expect_success 'partial clone: warn if server does not support object filte
test_create_repo server &&
test_commit -C server one &&
- git clone --filter=blobs:limit=0 "file://$(pwd)/server" client 2> err &&
+ git clone --filter=blob:limit=0 "file://$(pwd)/server" client 2> err &&
test_i18ngrep "filtering not recognized by server" err
'
@@ -673,7 +673,7 @@ test_expect_success 'batch missing blob request during checkout' '
test_config -C server uploadpack.allowfilter 1 &&
test_config -C server uploadpack.allowanysha1inwant 1 &&
- git clone --filter=blobs:limit=0 "file://$(pwd)/server" client &&
+ git clone --filter=blob:limit=0 "file://$(pwd)/server" client &&
# Ensure that there is only one negotiation by checking that there is
# only "done" line sent. ("done" marks the end of negotiation.)
@@ -705,7 +705,7 @@ test_expect_success 'batch missing blob request does not inadvertently try to fe
test_config -C server uploadpack.allowanysha1inwant 1 &&
# Make sure that it succeeds
- git clone --filter=blobs:limit=0 "file://$(pwd)/server" client
+ git clone --filter=blob:limit=0 "file://$(pwd)/server" client
'
. "$TEST_DIRECTORY"/lib-httpd.sh
-- 8< --
A similar patch to 't/t5300-pack-object.sh' gets one of the two
failing tests working. I haven't looked at 't/t5500-fetch-pack.sh'
yet.
ATB,
Ramsay Jones
next prev parent reply other threads:[~2017-11-08 22:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 20:28 Test failures on 'pu' branch Ramsay Jones
2017-11-08 20:36 ` Stefan Beller
2017-11-08 22:10 ` Jeff Hostetler
2017-11-08 22:34 ` Ramsay Jones [this message]
2017-11-08 22:55 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2d10701-2deb-4f03-f4ce-3da7d48effa3@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=jonathantanmy@google.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).