git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Alexey Borzenkov <snaury@gmail.com>
To: Pat Thoyts <patthoyts@users.sourceforge.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitk: restore wm state to normal before saving geometry  information
Date: Tue, 15 Sep 2009 17:58:24 +0400	[thread overview]
Message-ID: <e2480c70909150658p4293b596w6860d7cc9b3670ef@mail.gmail.com> (raw)
In-Reply-To: <e2480c70909150554p2e211d60y18049b5534f8922e@mail.gmail.com>

On Tue, Sep 15, 2009 at 4:54 PM, Alexey Borzenkov <snaury@gmail.com> wrote:
> On the other hand, when I resize columns and then maximize/restore the
> window repeatedly I see that their sizes change in a strange way (and
> the smaller restored window they stranger are results) until hitting
> some sort of equilibrium, then maximize/restore doesn't have effect on
> their sizes anymore. So maybe there's a bug not in a way my patch
> restores the window, but in a way window resizes are handled.

It seems that I found what's the problem. When the window is very
small, and we maximize it, sash coords would initially be small. Then
we calculate their new positions and set it with $win sash place, but
unfortunately, tk limits them to the OLD pane size for some reason.
Initially I though that maybe Configure is fired too early (before
window is resized), but [winfo width $win] shows $win has the new
size. Here's some output that I got during debugging:

resizing 422 -> 1261 (winfo shows 1261)
    s0: 138 1
    s1: 288 1
    sash0: 412 -> 412 1
    sash1: 860 -> 417 1

I'm at a loss why this happens and how to lift this restriction.

  reply	other threads:[~2009-09-15 13:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-08 19:22 [PATCH] gitk: restore wm state to normal before saving geometry information Alexey Borzenkov
2009-09-15  9:26 ` [PATCH 1/2] Work around leftover temporary save file Pat Thoyts
2009-09-15 13:01   ` Alex Riesen
2009-09-15 14:14     ` Alexey Borzenkov
2009-09-15 15:44       ` Pat Thoyts
2009-09-15 14:47     ` Pat Thoyts
2009-09-15  9:37 ` [PATCH 2/2] Fix the geometry when restoring from zoomed state Pat Thoyts
2009-09-15 14:11   ` Alexey Borzenkov
2009-09-17 12:15   ` [PATCH 2/2] gitk: " Paul Mackerras
2009-09-17 13:04     ` Alexey Borzenkov
2009-09-18 13:24     ` Pat Thoyts
2009-09-15 12:03 ` [PATCH] gitk: restore wm state to normal before saving geometry information Pat Thoyts
2009-09-15 12:54   ` Alexey Borzenkov
2009-09-15 13:58     ` Alexey Borzenkov [this message]
2009-09-16 10:21 ` Paul Mackerras
2009-09-16 21:07   ` Pat Thoyts
  -- strict thread matches above, loose matches on Subject: below --
2009-09-08 18:44 Alexey Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2480c70909150658p4293b596w6860d7cc9b3670ef@mail.gmail.com \
    --to=snaury@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=patthoyts@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).