From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-5.4 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 19CEA1F953 for ; Wed, 27 Oct 2021 20:08:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240438AbhJ0UK4 (ORCPT ); Wed, 27 Oct 2021 16:10:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37488 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235507AbhJ0UKz (ORCPT ); Wed, 27 Oct 2021 16:10:55 -0400 Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52D7CC061570 for ; Wed, 27 Oct 2021 13:08:29 -0700 (PDT) Received: by mail-qk1-x731.google.com with SMTP id h20so3607865qko.13 for ; Wed, 27 Oct 2021 13:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=BGuoS55bHrM9HrXgnKR/w5U6pXb7ldT9by+IidsCKj4=; b=maRX61XglkB/H24rbpiwJECd2+jrdmnQ/LJjrecjx7flEW7jVogBO9lCOL8qYrrVRx 1SPQxHKqne8ix5R39SuueGTASUhCTZZGRF25lMS9LiL9XHg2QuMJf4XsHHw2DwvqEO2r vqLbv7ueJNgxXOLa/1y2l2RFDlfyagMniVtM4it4phqjTV1O/wWYvSSfOzIRq8ev17I4 sr4VpqigVPkLRb8Ve83CXKv8OzgASGiUZ1IufZurlcdKWjy7t2mPsvPg6E1Y0Ma6yO/U jHqts6UqGIMfLVi9v2wzY1mP9wUI9E+ioXarHL+Kh6WvYP56Y6iv9HApRP5diSyLN4sF m4pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=BGuoS55bHrM9HrXgnKR/w5U6pXb7ldT9by+IidsCKj4=; b=W6oKiTgXmdJ7/rNAAgKx4ZyI15FJt0P+gyyp3nzTXjLeb3Qvm7OfGCNxahBbuOjZTC AuKpgT/VNo0/BQjKPd8+Orl5ZLvpGFBu7HOwzuUzoJWzeS68sci/hFu5RynD96XlyVp7 OASnqReS0PU8cMHKn/fgHLHyw9DFWFqf5bNmrzjkrUU9ePkUaYkjLjcKyo4ShIK4NjpW drAoBYRmX+gMT8QpcMHMGIZRXwb/bXmKDnk6jBrNys4bbUysKRv6TZH01zh16KFTV2Cx ZAcfFQ7zpftNWPFEZ3mipLJqSGubSpnJQgxUybadpti7yiXw7M9pvo7MYCYq5XoYHIw9 cYAg== X-Gm-Message-State: AOAM530MiiBEucQe60f3dcZ/csnEeVSu6n5mwEFWc3p+82C6OrTQi67U ZRLr0W7QXcPIiEF09EReiWk= X-Google-Smtp-Source: ABdhPJwTqXhUSHjpXr1cFPs3rhuXirrZQqjrW424FVWZu2t7IOjIKuD2bnobB+5/rn6Yfv63XDudQg== X-Received: by 2002:a05:620a:134f:: with SMTP id c15mr5849119qkl.97.1635365308473; Wed, 27 Oct 2021 13:08:28 -0700 (PDT) Received: from ?IPV6:2600:1700:e72:80a0:e44a:53c8:a196:8752? ([2600:1700:e72:80a0:e44a:53c8:a196:8752]) by smtp.gmail.com with ESMTPSA id r12sm671639qkp.11.2021.10.27.13.08.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Oct 2021 13:08:28 -0700 (PDT) Message-ID: Date: Wed, 27 Oct 2021 16:08:26 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH v3 0/3] sparse-index: expand/collapse based on 'index.sparse' Content-Language: en-US To: Victoria Dye via GitGitGadget , git@vger.kernel.org Cc: gitster@pobox.com, Victoria Dye References: From: Derrick Stolee In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 10/27/2021 2:20 PM, Victoria Dye via GitGitGadget wrote: > Changes since V2 > ================ > > * Rename can_convert_to_sparse to is_sparse_index_allowed to more > accurately reflect what the function returns. > * Remove index-iterating checks from is_sparse_index_allowed, leaving only > inexpensive checks on config settings & sparse checkout patterns. Checks > are still part of convert_to_sparse to ensure it behaves exactly as it > did before this series. > * Restructure ensure_correct_sparsity for better readability. > * Fix test_env variable scope. I took a full read through this version, taking special look at the changes since v2. I think this version is good to go! Thanks, -Stolee