From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 1DAF01F953 for ; Thu, 16 Dec 2021 14:24:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237920AbhLPOYk (ORCPT ); Thu, 16 Dec 2021 09:24:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229533AbhLPOYk (ORCPT ); Thu, 16 Dec 2021 09:24:40 -0500 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39478C061574 for ; Thu, 16 Dec 2021 06:24:40 -0800 (PST) Received: by mail-ot1-x330.google.com with SMTP id a23-20020a9d4717000000b0056c15d6d0caso29108771otf.12 for ; Thu, 16 Dec 2021 06:24:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=LF03jEmiN2UJW2RbkbN67QugpGDUxCY+F2THBBlEN6A=; b=DUfH4bcyuF93o/bvt0pP/i5LocKwLl0OMQvbjN3CyeSZBK6NOMN3UzF25qaAcLkd4/ N/KxiNagFa1rotuMOwh8iRuQm5BXkw1s0XU6dTFXrYoNGbJPt6/8w3qzTrqFwIZjef+P 6dZQXq4TdYlhsECAmy0QI25DjNN9VBoJ9YwUo9oUcPEl1dahy3o2+h1Kw4NEJXc/x+l2 O7WWfnMgsnzqMIfYutKxBaEhJv92vGcL/TpI+/LMlDRFrZWxsVtJ4r2+Q+pSgytebja3 XaF39jVBSsn2hA60YNcf7d8jmM1i9RMfWH93KIfaS6zpHEgFjYaOIJO05LNaIkN5aX0s yffA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LF03jEmiN2UJW2RbkbN67QugpGDUxCY+F2THBBlEN6A=; b=qfFphIwUajIn/lpIGmN8ByfSKkX8kQbHhvrCFA9D5ho8dJjqJ4qG9auTABnMd/eKRl Haj3BnkbZi9/0oK9clBDUpI9WhK1XQbEgWUO1VTb6xMOTKq7R7VWIW3FVsFH+C74Gl+w l4bT0oaWBmLLTbAK4E3mAWmafWZz/Au7spRrQ0w0JUaPoubip3p7sKcLxNh2cwyKYJW5 vu2vFlXHGUXPnlg4r8pgO6Ny76YUIJokgV/CRSnQkyLI8sYR6nyEVPlgYJ/CnVX8eGta 7bMA53DvQlUGD0nrYbZKJroeWld5wpUbSXyE+dU8Q13mlArijYEFLNliVeHeC69u/n7i 922A== X-Gm-Message-State: AOAM533VtlBtOBXjlJpmKIMz6FCP3Vq7NBvNfV0r2mJ1SI7yHyOVVwcs HqA8JRYbHZsmDaYQQiL2HrgKA25ed4w= X-Google-Smtp-Source: ABdhPJwGazE8ZwUL43vA9F/naWmw6ET9STiGMtTgEkHlDHc/O4n2ffOh6t5Im0O/lzmC+3Ng58WBAw== X-Received: by 2002:a05:6830:2681:: with SMTP id l1mr12667731otu.378.1639664678143; Thu, 16 Dec 2021 06:24:38 -0800 (PST) Received: from ?IPV6:2600:1700:e72:80a0:f174:15fc:4a5c:9d45? ([2600:1700:e72:80a0:f174:15fc:4a5c:9d45]) by smtp.gmail.com with ESMTPSA id ay40sm956377oib.1.2021.12.16.06.24.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Dec 2021 06:24:37 -0800 (PST) Message-ID: Date: Thu, 16 Dec 2021 09:24:35 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v3 0/3] sparse-checkout: fix segfault on malformed patterns Content-Language: en-US To: Junio C Hamano , Derrick Stolee via GitGitGadget Cc: git@vger.kernel.org, me@ttaylorr.com, newren@gmail.com, vdye@github.com, Derrick Stolee References: From: Derrick Stolee In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 12/15/2021 3:43 PM, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" writes: > >> This series fixes some issues with parsing sparse-checkout patterns when >> core.sparseCheckoutCone is enabled but the sparse-checkout file itself >> contains patterns that don't match the cone mode format. >> >> The first patch fixes a segfault first reported in [1]. The other two >> patches are from an earlier submission [2] that never got picked up and I >> lost track of. There was another patch involving 'git sparse-checkout init >> --cone' that isn't necessary, especially with Elijah doing some work in that >> space right now. > > Thanks. The segfault fix matters even more with Elijah's "we can > flip between modes" feature, right? Generally, I think segfaults are a higher priority, but this one is hard to find in the wild, I think. I'll send a v4 today and hopefully it makes it an easy decision for you. Thanks, -Stolee