From: Andrzej Hunt <email@example.com> To: Derrick Stolee <firstname.lastname@example.org>, Junio C Hamano <email@example.com>, Andrzej Hunt via GitGitGadget <firstname.lastname@example.org>, Derrick Stolee <email@example.com>, Abhishek Kumar <firstname.lastname@example.org>, Taylor Blau <email@example.com> Cc: firstname.lastname@example.org, Andrzej Hunt <email@example.com> Subject: Re: [PATCH] commit-graph: avoid leaking topo_levels slab in write_commit_graph() Date: Mon, 22 Feb 2021 20:14:15 +0100 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> On 22/02/2021 15:15, Derrick Stolee wrote: > This change looks like a sane change to me. It definitely fixes a leak. > The leak "wasn't hurting anybody" because write_commit_graph() is only > called at most once per process, and the process closes itself out > shortly after. Still, it's good to have good memory hygiene here. Good to know - thank you! As I become more familiar with git, I'm beginning to realise that most leaks are unlikely to be much importance (even though I personally err on the side of fixing any and all issues). One thing I forgot to mention: in this specific case the leak was causing a build failure when trying to build git's fuzzers within oss-fuzz locally*. Specifically the following command would fail (see also fuzz failure reproduction instructions which describe the setup ). $ python infra/helper.py build_fuzzers --sanitizer address git As far as I can tell the issue is that: a copy of git built with ASAN is used to produce the fuzzing corpus as part of the git-specific build script  - the leak warning causes the script to fail. (It's possible to argue that the build script should disable ASAN's leak checking when running git, via detect_leaks=0 to reduce the risk of such breakage - I may try to suggest such a change to oss-fuzz.) ATB, Andrzej * Given that oss-fuzz is building via docker, I would intuitively suspect that the same issue occurs in automation - I'm not sure how to verify this myself.  https://google.github.io/oss-fuzz/advanced-topics/reproducing/#building-using-docker  https://github.com/google/oss-fuzz/blob/1b0115eefd70491376cf3cb6f88e49632c78ee18/projects/git/build.sh#L37
next prev parent reply other threads:[~2021-02-22 19:31 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-19 20:13 Andrzej Hunt via GitGitGadget 2021-02-20 3:36 ` Junio C Hamano 2021-02-22 14:15 ` Derrick Stolee 2021-02-22 19:14 ` Andrzej Hunt [this message] 2021-02-25 6:26 Abhishek Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH] commit-graph: avoid leaking topo_levels slab in write_commit_graph()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).