From: "Kristoffer Haugsbakk" <code@khaugsbakk.name>
To: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: range-diff: slight usability problem with mistyped ref
Date: Mon, 03 Apr 2023 21:29:17 +0200 [thread overview]
Message-ID: <de43cd37-bfa5-4dbc-84d5-9362e9af6a9a@app.fastmail.com> (raw)
In-Reply-To: <818b3ad0-df43-3484-8c19-d95026f6b2b1@gmx.de>
Hi Johannes and thanks for your reply
On Tue, Mar 28, 2023, at 13:37, Johannes Schindelin wrote:
> So even making the exact error message depend on the number of
> arguments could result in misleading error message.
Yeah, I see. It seems that the variadic nature of the command makes it
difficult to guess what the user might have meant in all cases.
> Do you have any splendid idea how to phrase the error message (or
> adapt it to the concrete invocation)?
No. I was going to look more closely at that if-else chain, but given
the fact that I don’t know C and all the cases that would need to be
covered (“what if the third argument happens to match both a ref and a
file?”) I wouldn’t get anywhere.
--
Kristoffer Haugsbakk
next prev parent reply other threads:[~2023-04-03 19:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 10:04 range-diff: slight usability problem with mistyped ref Kristoffer Haugsbakk
2023-03-28 11:37 ` Johannes Schindelin
2023-04-03 19:29 ` Kristoffer Haugsbakk [this message]
2023-04-04 20:20 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de43cd37-bfa5-4dbc-84d5-9362e9af6a9a@app.fastmail.com \
--to=code@khaugsbakk.name \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).