From: "Johannes Sixt via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Johannes Sixt" <j6t@kdbg.org>, "Johannes Sixt" <j6t@kdbg.org>
Subject: [PATCH v2 4/5] userdiff-cpp: permit the digit-separating single-quote in numbers
Date: Fri, 08 Oct 2021 19:09:56 +0000 [thread overview]
Message-ID: <dd75d19cee9a911de93d19585c888c57fe8c3aee.1633720197.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1054.v2.git.1633720197.gitgitgadget@gmail.com>
From: Johannes Sixt <j6t@kdbg.org>
Since C++17, the single-quote can be used as digit separator:
3.141'592'654
1'000'000
0xdead'beaf
Make it known to the word regex of the cpp driver, so that numbers are
not split into separate tokens at the single-quotes.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
t/t4034/cpp/expect | 10 +++++-----
t/t4034/cpp/post | 8 ++++----
t/t4034/cpp/pre | 8 ++++----
userdiff.c | 6 +++---
4 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/t/t4034/cpp/expect b/t/t4034/cpp/expect
index 46c9460a968..a3a234f5461 100644
--- a/t/t4034/cpp/expect
+++ b/t/t4034/cpp/expect
@@ -1,5 +1,5 @@
<BOLD>diff --git a/pre b/post<RESET>
-<BOLD>index 1229cdb..3feae6f 100644<RESET>
+<BOLD>index 60f3640..f6fbf7b 100644<RESET>
<BOLD>--- a/pre<RESET>
<BOLD>+++ b/post<RESET>
<CYAN>@@ -1,30 +1,30 @@<RESET>
@@ -7,15 +7,15 @@ Foo() : x(0<RED>&&1<RESET><GREEN>&42<RESET>) { <RED>foo0<RESET><GREEN>bar<RESET>
cout<<"Hello World<RED>!<RESET><GREEN>?<RESET>\n"<<endl;
<GREEN>(<RESET>1 <RED>-<RESET><GREEN>+<RESET>1e10 0xabcdef<GREEN>)<RESET> '<RED>x<RESET><GREEN>y<RESET>'
// long double<RESET>
-<RED>3.141592653e-10l<RESET><GREEN>3.141592654e+10l<RESET>
+<RED>3.141'592'653e-10l<RESET><GREEN>3.141'592'654e+10l<RESET>
// float<RESET>
<RED>120E5f<RESET><GREEN>120E6f<RESET>
// hex<RESET>
-<RED>0xdeadbeaf<RESET><GREEN>0xdeadBeaf<RESET>+<RED>8ULL<RESET><GREEN>7ULL<RESET>
+<RED>0xdead'beaf<RESET><GREEN>0xdead'Beaf<RESET>+<RED>8ULL<RESET><GREEN>7ULL<RESET>
// octal<RESET>
-<RED>01234567<RESET><GREEN>01234560<RESET>
+<RED>0123'4567<RESET><GREEN>0123'4560<RESET>
// binary<RESET>
-<RED>0b1000<RESET><GREEN>0b1100<RESET>+e1
+<RED>0b10'00<RESET><GREEN>0b11'00<RESET>+e1
// expression<RESET>
1.5-e+<RED>2<RESET><GREEN>3<RESET>+f
// another one<RESET>
diff --git a/t/t4034/cpp/post b/t/t4034/cpp/post
index 3feae6f430f..f6fbf7bc04c 100644
--- a/t/t4034/cpp/post
+++ b/t/t4034/cpp/post
@@ -2,15 +2,15 @@ Foo() : x(0&42) { bar(x.Find); }
cout<<"Hello World?\n"<<endl;
(1 +1e10 0xabcdef) 'y'
// long double
-3.141592654e+10l
+3.141'592'654e+10l
// float
120E6f
// hex
-0xdeadBeaf+7ULL
+0xdead'Beaf+7ULL
// octal
-01234560
+0123'4560
// binary
-0b1100+e1
+0b11'00+e1
// expression
1.5-e+3+f
// another one
diff --git a/t/t4034/cpp/pre b/t/t4034/cpp/pre
index 1229cdb59d1..60f3640d773 100644
--- a/t/t4034/cpp/pre
+++ b/t/t4034/cpp/pre
@@ -2,15 +2,15 @@ Foo():x(0&&1){ foo0( x.find); }
cout<<"Hello World!\n"<<endl;
1 -1e10 0xabcdef 'x'
// long double
-3.141592653e-10l
+3.141'592'653e-10l
// float
120E5f
// hex
-0xdeadbeaf+8ULL
+0xdead'beaf+8ULL
// octal
-01234567
+0123'4567
// binary
-0b1000+e1
+0b10'00+e1
// expression
1.5-e+2+f
// another one
diff --git a/userdiff.c b/userdiff.c
index ce2a9230703..1b640c7df79 100644
--- a/userdiff.c
+++ b/userdiff.c
@@ -57,11 +57,11 @@ PATTERNS("cpp",
/* identifiers and keywords */
"[a-zA-Z_][a-zA-Z0-9_]*"
/* decimal and octal integers as well as floatingpoint numbers */
- "|[0-9][0-9.]*([Ee][-+]?[0-9]+)?[fFlLuU]*"
+ "|[0-9][0-9.']*([Ee][-+]?[0-9]+)?[fFlLuU]*"
/* hexadecimal and binary integers */
- "|0[xXbB][0-9a-fA-F]+[lLuU]*"
+ "|0[xXbB][0-9a-fA-F']+[lLuU]*"
/* floatingpoint numbers that begin with a decimal point */
- "|\\.[0-9]+([Ee][-+]?[0-9]+)?[fFlL]?"
+ "|\\.[0-9']+([Ee][-+]?[0-9]+)?[fFlL]?"
"|[-+*/<>%&^|=!]=|--|\\+\\+|<<=?|>>=?|&&|\\|\\||::|->\\*?|\\.\\*"),
PATTERNS("csharp",
/* Keywords */
--
gitgitgadget
next prev parent reply other threads:[~2021-10-08 19:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 6:50 [PATCH 0/3] Fun with cpp word regex Johannes Sixt via GitGitGadget
2021-10-07 6:50 ` [PATCH 1/3] userdiff: tighten " Johannes Sixt via GitGitGadget
2021-10-07 6:50 ` [PATCH 2/3] userdiff: permit the digit-separating single-quote in numbers Johannes Sixt via GitGitGadget
2021-10-07 6:51 ` [PATCH 3/3] userdiff: learn the C++ spaceship operator Johannes Sixt via GitGitGadget
2021-10-07 9:14 ` [PATCH 0/3] Fun with cpp word regex Ævar Arnfjörð Bjarmason
2021-10-07 16:40 ` Johannes Sixt
2021-10-08 19:09 ` [PATCH v2 0/5] " Johannes Sixt via GitGitGadget
2021-10-08 19:09 ` [PATCH v2 1/5] t4034/cpp: actually test that operator tokens are not split Johannes Sixt via GitGitGadget
2021-10-08 19:09 ` [PATCH v2 2/5] t4034: add tests showing problematic cpp tokenizations Johannes Sixt via GitGitGadget
2021-10-08 19:09 ` [PATCH v2 3/5] userdiff-cpp: tighten word regex Johannes Sixt via GitGitGadget
2021-10-08 19:09 ` Johannes Sixt via GitGitGadget [this message]
2021-10-08 19:09 ` [PATCH v2 5/5] userdiff-cpp: learn the C++ spaceship operator Johannes Sixt via GitGitGadget
2021-10-08 20:07 ` [PATCH v2 0/5] Fun with cpp word regex Ævar Arnfjörð Bjarmason
2021-10-08 22:11 ` Johannes Sixt
2021-10-09 0:00 ` Ævar Arnfjörð Bjarmason
2021-10-10 20:15 ` Johannes Sixt
2021-10-10 17:02 ` [PATCH v3 0/6] " Johannes Sixt via GitGitGadget
2021-10-10 17:02 ` [PATCH v3 1/6] t4034/cpp: actually test that operator tokens are not split Johannes Sixt via GitGitGadget
2021-10-10 17:03 ` [PATCH v3 2/6] t4034: add tests showing problematic cpp tokenizations Johannes Sixt via GitGitGadget
2021-10-10 17:03 ` [PATCH v3 3/6] userdiff-cpp: tighten word regex Johannes Sixt via GitGitGadget
2021-10-10 17:03 ` [PATCH v3 4/6] userdiff-cpp: prepare test cases with yet unsupported features Johannes Sixt via GitGitGadget
2021-10-10 17:03 ` [PATCH v3 5/6] userdiff-cpp: permit the digit-separating single-quote in numbers Johannes Sixt via GitGitGadget
2021-10-10 17:03 ` [PATCH v3 6/6] userdiff-cpp: learn the C++ spaceship operator Johannes Sixt via GitGitGadget
2021-10-24 9:56 ` [PATCH 7/6] userdiff-cpp: back out the digit-separators in numbers Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd75d19cee9a911de93d19585c888c57fe8c3aee.1633720197.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).