From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 853A21F54E for ; Thu, 1 Sep 2022 02:29:21 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=plus.com header.i=@plus.com header.b="kkoYHWSL"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232756AbiIAC2s (ORCPT ); Wed, 31 Aug 2022 22:28:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232808AbiIAC2k (ORCPT ); Wed, 31 Aug 2022 22:28:40 -0400 X-Greylist: delayed 181 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 31 Aug 2022 19:28:38 PDT Received: from avasout-ptp-003.plus.net (avasout-ptp-003.plus.net [84.93.230.244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B7BB10B945 for ; Wed, 31 Aug 2022 19:28:37 -0700 (PDT) Received: from [10.0.2.15] ([147.147.167.40]) by smtp with ESMTPA id TZtSoUPGLLmeETZtToMfy5; Thu, 01 Sep 2022 03:25:33 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=plus.com; s=042019; t=1661999133; bh=fLPau/eX+87rz79nZK20guOtyYvBNosmuIU66VDplJk=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=kkoYHWSLy/Wr9VKNuEEjh1s6JPtR750AS1qf+cyiNen5g8EMP//pDj1/dRINyfJLu Y4yuFE9Q8EpFmG/nKaVwuHAStCCn0XYOWKwt5+ukUk1cPy16BQ5XErFxp7FMYHPqGO r2yIwoKscCjz6vJCqKhl4PtRwpDWvmJrcigrRUNMMpejSaeqdh5UlpWJ+m1csUqRNZ p+HhEpGp7f6kqIvgdhqd8OexBk0N3glbKIDfgRAGnFPcKKoAHPAPKgi/qdAVKq+5sm qbXpitryMGSkp+gqdVSOmIljfktTDH0zYORkH9T9zAylB273pp8B3fuRVNBwLv4ZKv ue6BbxERUlxkA== X-Clacks-Overhead: "GNU Terry Pratchett" X-CM-Score: 0.00 X-CNFS-Analysis: v=2.4 cv=M/5elg8s c=1 sm=1 tr=0 ts=6310181d a=nyqnwr6A7Kzjd6EpZhiMcA==:117 a=nyqnwr6A7Kzjd6EpZhiMcA==:17 a=IkcTkHD0fZMA:10 a=pGLkceISAAAA:8 a=s8AV3YTns38XMBn0O3EA:9 a=QEXdDO2ut3YA:10 a=iMKwS5WCztSl3EfDOHEb:22 X-AUTH: ramsayjones@:2500 Message-ID: Date: Thu, 1 Sep 2022 03:25:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4 1/4] fsmonitor: add two new config options, allowRemote and socketDir Content-Language: en-GB To: Junio C Hamano , Eric DeCosta via GitGitGadget Cc: git@vger.kernel.org, Eric DeCosta References: <836a791e6b7fd4490674254ce03105a8ca2175cb.1661962145.git.gitgitgadget@gmail.com> From: Ramsay Jones In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfOqL8Hn7HbHBoZvGXUwtQ25He+w5jd+qJwN4N6Kd1A3kP5YHWlPf3Npn4Jm6bYX3uYuXieD7a4KniiA+DsMuoHY1wAAsaq5seRSMoC51F9s8sFubgHmM RKhNghX9AszAqmP0YlaFR8qgDUR+5ENhXL43gWYdKQinQ1czhmpl2q053meBQVmHTb4VgsF1aavNYFj70RLTVSGGVqrvkcfU3cc= Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 31/08/2022 21:04, Junio C Hamano wrote: > "Eric DeCosta via GitGitGadget" writes: > [snip] >> diff --git a/fsmonitor-settings.h b/fsmonitor-settings.h >> index d9c2605197f..2de54c85e94 100644 >> --- a/fsmonitor-settings.h >> +++ b/fsmonitor-settings.h >> @@ -23,12 +23,16 @@ enum fsmonitor_reason { >> FSMONITOR_REASON_NOSOCKETS, /* NTFS,FAT32 do not support Unix sockets */ >> }; >> >> +void fsm_settings__set_allow_remote(struct repository *r); >> +void fsm_settings__set_socket_dir(struct repository *r); > > Do these two need to be extern? > On 'seen' after building: ... $ ./static-check.pl >ssc $ diff nsc ssc 3a4 > bundle-uri.o - for_all_bundles_in_list 15d15 < config.o - git_config_from_file_with_options 40a41,43 > fsmonitor-settings.o - fsm_settings__get_allow_remote > fsmonitor-settings.o - fsm_settings__get_socket_dir > fsmonitor-settings.o - fsm_settings__set_allow_remote 44a48 > fsmonitor-settings.o - fsm_settings__set_socket_dir $ .. so probably not. ;-) ATB, Ramsay Jones