From: Sven Strickroth <email@cs-ware.de>
To: git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: tortoiseplink ssh variant still needed?
Date: Fri, 22 Oct 2021 18:13:20 +0200 [thread overview]
Message-ID: <dad761bf-3121-8934-fad6-78610bc21121@cs-ware.de> (raw)
Hi,
Git differentiates between different variants of SSH tools.
One variant is the tortoiseplink variant. When this is configured Git
passes passes a special "--batch" parameter and passes the port using
"-P" (capitalized P) t the SSH tool.
IIRC tortoiseplink was initially created by TortoiseCVS which is
nowadays not maintained any more
(<http://www.tortoisecvs.org/download.shtml>).
In TortoiseSVN and TortoiseGit tortoiseplink was modified six years ago
(around 2015-03-07) to ignore the "--batch" parameter and also accept
"-p" additionally to "-P" (cf.
<https://osdn.net/projects/tortoisesvn/scm/svn/commits/26348>).
Therefore, my first question: Does Git still want to support very old
versions of tortoiseplink or should I provide a patch which drops
support for it?
Second question:
TortoiseGit comes with an even more improved version of TortoisePLink
(named TortoiseGitPLink, but also ships the same binary as
tortoiseplink) that also accepts "-o SetEnv=..." parameters in order to
support the Git protocol version 2. At the moment TortoiseGit
automatically sets the environment variable "GIT_SSH_VARIANT=ssh". This
works, but is not perfect if other parameter of OpenSSH are used. Would
it make sense to add a new ssh variant tortoisegitplink? If yes, how to
handle new versions that might also support even more OpenSSH command
line parameters?
--
Best regards,
Sven Strickroth
PGP key id F5A9D4C4 @ any key-server
next reply other threads:[~2021-10-22 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 16:13 Sven Strickroth [this message]
2021-10-22 16:45 ` [PATCH] Drop unneeded special handling of ssh variant tortoiseplink Sven Strickroth
2021-10-23 9:57 ` Ævar Arnfjörð Bjarmason
2021-10-23 21:53 ` tortoiseplink ssh variant still needed? Junio C Hamano
2021-10-25 13:04 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dad761bf-3121-8934-fad6-78610bc21121@cs-ware.de \
--to=email@cs-ware.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).