From: Jeff Hostetler <git@jeffhostetler.com>
To: Garima Singh <garimasigit@gmail.com>,
Garima Singh via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command
Date: Wed, 11 Sep 2019 14:17:42 -0400 [thread overview]
Message-ID: <da9a7ce5-736c-9d85-d655-cb19172063f8@jeffhostetler.com> (raw)
In-Reply-To: <6d1e51c3-64a4-0075-5c9c-3302c5d07c50@gmail.com>
On 9/10/2019 9:54 AM, Garima Singh wrote:
> Ping :) Any thoughts on this?
>
> On 8/27/2019 12:56 PM, Garima Singh via GitGitGadget wrote:
>> Emit trace2_cmd_mode() messages for each commit-graph sub-command.
>>
>> The commit graph commands were in flux when trace2 was making it's way to
>> git. Now that we have enough sub-commands in commit-graph, we can
>> label the
>> various modes within them. Distinguishing between read, write and
>> verify is
>> a great start.
>>
>> Signed-off-by: Garima Singh garima.singh@microsoft.com
>> [garima.singh@microsoft.com]
>>
>> CC: jeffhost@microsoft.com, stolee@gmail.com, garimasigit@gmail.com,
>> avarab@gmail.com
>>
>> Garima Singh (1):
>> commit-graph: emit trace2 cmd_mode for each sub-command
>>
>> builtin/commit-graph.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>>
>> base-commit: 745f6812895b31c02b29bdfe4ae8e5498f776c26
>> Published-As:
>> https://github.com/gitgitgadget/git/releases/tag/pr-323%2Fgarimasi514%2FcoreGit-commit-graph-trace2-v1
>>
>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git
>> pr-323/garimasi514/coreGit-commit-graph-trace2-v1
>> Pull-Request: https://github.com/gitgitgadget/git/pull/323
>>
Looks good to me. Thanks!
Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
next prev parent reply other threads:[~2019-09-11 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 16:56 [PATCH 0/1] commit-graph: emit trace2 cmd_mode for each sub-command Garima Singh via GitGitGadget
2019-08-27 16:56 ` [PATCH 1/1] " Garima Singh via GitGitGadget
2019-09-10 13:54 ` [PATCH 0/1] " Garima Singh
2019-09-11 18:17 ` Jeff Hostetler [this message]
2019-10-02 8:02 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da9a7ce5-736c-9d85-d655-cb19172063f8@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=garimasigit@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).