git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Philip Oakley <philipoakley@iee.email>
To: Maksym Sobolyev via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Cc: Maksym Sobolyev <sobomax@gmail.com>,
	Maksym Sobolyev <sobomax@sippysoft.com>
Subject: Re: [PATCH] Make ident dynamic, not just a hardcoded value of "$Id".
Date: Mon, 23 Aug 2021 19:41:22 +0100	[thread overview]
Message-ID: <da4e66ec-0613-a8ba-0b69-cd247fcd457b@iee.email> (raw)
In-Reply-To: <pull.1074.git.git.1629736918861.gitgitgadget@gmail.com>

On 23/08/2021 17:41, Maksym Sobolyev via GitGitGadget wrote:
> From: Maksym Sobolyev <sobomax@sippysoft.com>
>
> This allows ident to be something like $FreeBSD$ so it provides matching
> functionality for repos migrated from CVS / SVN.
>
> This works by allowing ident to have a parameter, i.e.:
>
> * ident=MyCustomId
>
> In .gitattributes.
>
> Signed-off-by: Maksym Sobolyev <sobomax@sippysoft.com>
> ---
>     Make ident dynamic, not just a hardcoded value of "$Id".
>     
>     This allows ident to be something like $FreeBSD$ so it provides matching
>     functionality for repos migrated from CVS / SVN.
>     
>     This works by allowing ident to have a parameter, i.e.:
>     
>     * ident=MyCustomId
>     
>     In .gitattributes.
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1074%2Fsobomax%2Fpr-custom_ident-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1074/sobomax/pr-custom_ident-v1
> Pull-Request: https://github.com/git/git/pull/1074
>
>  builtin/checkout--worker.c              |  17 +++-
>  convert.c                               | 114 +++++++++++++++---------
>  convert.h                               |   7 +-
>  parallel-checkout.c                     |  11 ++-
>  parallel-checkout.h                     |   8 +-
>  t/t2082-parallel-checkout-attributes.sh |   7 +-
>  6 files changed, 108 insertions(+), 56 deletions(-)
>
> diff --git a/builtin/checkout--worker.c b/builtin/checkout--worker.c

Should this also include some documentation updates?
-- 
Philip

  parent reply	other threads:[~2021-08-23 18:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23 16:41 [PATCH] Make ident dynamic, not just a hardcoded value of "$Id" Maksym Sobolyev via GitGitGadget
2021-08-23 18:10 ` Junio C Hamano
2021-08-23 18:41 ` Philip Oakley [this message]
2021-08-26  4:28 ` [PATCH v2] " Maksym Sobolyev via GitGitGadget
2021-08-26 20:37   ` Matheus Tavares
2021-09-02  0:58     ` Junio C Hamano
2021-09-02 19:04       ` Junio C Hamano
2021-08-27  2:59   ` Junio C Hamano
     [not found]     ` <CABFYoQC_FzbU_E4hU0kCz-WFJNOLspwL2Gjc01sMXDZosxJWjw@mail.gmail.com>
2021-09-01  5:35       ` Junio C Hamano
2021-09-01  2:13   ` [PATCH v3] " Maksym Sobolyev via GitGitGadget
2021-09-02  3:40     ` Đoàn Trần Công Danh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da4e66ec-0613-a8ba-0b69-cd247fcd457b@iee.email \
    --to=philipoakley@iee.email \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=sobomax@gmail.com \
    --cc=sobomax@sippysoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).