From: Philip Oakley <philipoakley@iee.org>
To: Chris Webster <chris@webstech.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: "Chris. Webster via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 1/1] diff-highlight: Use correct /dev/null for UNIX and Windows
Date: Sun, 12 May 2019 21:24:47 +0100 [thread overview]
Message-ID: <d8bd7df9-ec1a-3012-488e-1986dee9c9a5@iee.org> (raw)
In-Reply-To: <CAGT1KpVn536+B6-8=opNAVnz3_w13Kx3LyED0Gbk+4DtwmoP6Q@mail.gmail.com>
Hi Chris,
On 07/05/2019 05:18, Chris Webster wrote:
> I know these can take some time but is this pending any update from
> me? The accepted changes will be merged back into the diff-so-fancy
> project.
>
> There was a question about other uses of /dev/null. In the contrib
> directory, there are a couple of uses.
>
> contrib/buildsystems/engine.pl - not clear if this is still of use or
> always expects to always be running in a mingw type environment.
While the `contrib/buildsystems/engine.pl ` is not often used, it does
provide a route for users of older Visual studio version.
I'm not sure if the mingw environment is relevant to its operation - I'd
expect it (the generation of an .sln that would compile) to still work
with the current MSYS2 basis, but the `install` process was never fully
completed (an probably isn't a worthwhile project unless you have the
particular itch to scratch).
The newer MSVC=1 build process using vcpkg has solved most of the
issues, but I'm getting a couple of issues with some of the
libraries/include paths with the latest VS2017, see issue #2186 / #2179
/ https://groups.google.com/forum/#!topic/git-for-windows/Y99a0dzlVJY ,
though hopefully I'll get them sorted this week.
> contrib/mw-to-git/git-remote-mediawiki.perl - this is cloned from a
> separately maintained github project. Should any changes be issues on
> that project?
>
> thanks,
> ...chris.
>
> On Tue, Nov 6, 2018 at 6:02 AM Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
>> List,
>>
>> I have no idea why this mail made it to GitGitGadget's email account but
>> not to the Git mailing list... Sorry about that.
>>
>> Ciao,
>> Johannes
>>
>> On Wed, 31 Oct 2018, Chris. Webster via GitGitGadget wrote:
>>
>>> From: "Chris. Webster" <chris@webstech.net>
>>>
>>> Use File::Spec->devnull() for output redirection to avoid messages
>>> when Windows version of Perl is first in path. The message 'The
>>> system cannot find the path specified.' is displayed each time git is
>>> run to get colors.
>>>
>>> Signed-off-by: Chris. Webster <chris@webstech.net>
>>> ---
>>> contrib/diff-highlight/DiffHighlight.pm | 7 ++++++-
>>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/contrib/diff-highlight/DiffHighlight.pm b/contrib/diff-highlight/DiffHighlight.pm
>>> index 536754583b..7440aa1c46 100644
>>> --- a/contrib/diff-highlight/DiffHighlight.pm
>>> +++ b/contrib/diff-highlight/DiffHighlight.pm
>>> @@ -4,6 +4,11 @@ use 5.008;
>>> use warnings FATAL => 'all';
>>> use strict;
>>>
>>> +# Use the correct value for both UNIX and Windows (/dev/null vs nul)
>>> +use File::Spec;
>>> +
>>> +my $NULL = File::Spec->devnull();
>>> +
>>> # Highlight by reversing foreground and background. You could do
>>> # other things like bold or underline if you prefer.
>>> my @OLD_HIGHLIGHT = (
>>> @@ -134,7 +139,7 @@ sub highlight_stdin {
>>> # fallback, which means we will work even if git can't be run.
>>> sub color_config {
>>> my ($key, $default) = @_;
>>> - my $s = `git config --get-color $key 2>/dev/null`;
>>> + my $s = `git config --get-color $key 2>$NULL`;
>>> return length($s) ? $s : $default;
>>> }
>>>
>>> --
>>> gitgitgadget
>>>
next prev parent reply other threads:[~2019-05-12 20:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 18:26 [PATCH 0/1] DiffHighlight.pm: Use correct /dev/null for UNIX and Windows Chris. Webster via GitGitGadget
2018-10-30 18:26 ` [PATCH 1/1] " chris via GitGitGadget
2018-10-31 3:56 ` Jeff King
2018-10-31 4:48 ` Junio C Hamano
2018-10-31 4:54 ` Junio C Hamano
[not found] ` <CAGT1KpWoGD0xgTrC-+X1WqY_M=2arYbs4ZX6Nnj-zHK6mgu+nw@mail.gmail.com>
2018-10-31 5:41 ` Chris Webster
2018-10-31 6:08 ` Junio C Hamano
2018-10-31 11:10 ` Johannes Schindelin
2018-11-01 1:57 ` Junio C Hamano
2018-10-31 5:07 ` Junio C Hamano
2018-10-31 11:14 ` Johannes Schindelin
2018-10-31 22:58 ` [PATCH v2 0/1] DiffHighlight.pm: " Chris. Webster via GitGitGadget
[not found] ` <bcbffa141116f869db40e4572f9824a3d090c20c.1541026721.git.gitgitgadget@gmail.com>
2018-11-06 14:01 ` [PATCH v2 1/1] diff-highlight: " Johannes Schindelin
2019-05-07 4:18 ` Chris Webster
2019-05-12 20:24 ` Philip Oakley [this message]
2019-05-08 10:45 ` Fwd: " Git Gadget
2019-05-09 3:19 ` Junio C Hamano
2019-05-09 18:52 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8bd7df9-ec1a-3012-488e-1986dee9c9a5@iee.org \
--to=philipoakley@iee.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=chris@webstech.net \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).