From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 022B21F5AE for ; Sat, 24 Jul 2021 14:14:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233598AbhGXNdz (ORCPT ); Sat, 24 Jul 2021 09:33:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbhGXNdx (ORCPT ); Sat, 24 Jul 2021 09:33:53 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAFEEC061575 for ; Sat, 24 Jul 2021 07:14:25 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id h24-20020a1ccc180000b029022e0571d1a0so3317132wmb.5 for ; Sat, 24 Jul 2021 07:14:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:in-reply-to:references:from:date:subject:fcc :content-transfer-encoding:mime-version:to:cc; bh=O9u986p91/Gwi+fKy8spnM0GBKp3DiyL5kpCBbLklIA=; b=FASAhyMGTt/MkMMfGc5609LzBYdCrsP6Nv6tWfdPZ18ulQoaq9zVBE7YOFMYHrA6rw /VTm2MaK0KWDFjCPH/pPD+hmYVvAPznk46NZUT+kvDSpJt1IjtiMAcaGpLbQTTkU5qXw PdBHZGf7avTFm2+Bcu+qPlq9Oe+seODGxMqOJbXimLXb7I60KwJYGTjnO9kkdjgkyO/x nmeG2HF8mAbRS3DjBGPJfcNKQemp2pVZo7gpm8Rel1KABKfcR5G3uko9ElX6G8d7HsAh 77XSwXXFz5nRkvVVkNg1uAsMNiUHrjdvQcRZ/WAzSBye7f/bmmOzgbLf8TAScGIu73l3 oq3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:in-reply-to:references:from:date :subject:fcc:content-transfer-encoding:mime-version:to:cc; bh=O9u986p91/Gwi+fKy8spnM0GBKp3DiyL5kpCBbLklIA=; b=faFMOtnGqFeJvcVQdTA1ggnMDfexbnu2jbf/eM96zDbOOIlggPh9LXvnGufF3harn6 EsByWNkHEGHSffVh2PA89u0eRYnvf0B1m8opzQshnMwTPSv3Ub5vQnO5a81jMAmNOkpq RrPqSnS2vgreaQQD4yPibgt4kbMCaS/eKXMZ2x9Xbt/VnMFgq4833YqwvLtldoArC+8V tTohRFWtFa57MH6lgFuGor1TAabIMO2HN489uh8EkCeSaXeGz2toCtRpUGqzTx4pRwHx sbuAKgBwnyRI+mzC2WaqrWU4ZTv8bnMN8mM/D5NoYdQmpEk2bnmJpTB4/OHpMxoyhFi9 TICQ== X-Gm-Message-State: AOAM530aX24sIXKeJiHuwlDWQuSj2UevcyCFmGXnZyJwdsUlUrPUlfYQ tig8TJ5J3OYaj81sKV+tLWx08X7jylk= X-Google-Smtp-Source: ABdhPJzpkh17uDGpvIVWBGQxD/8adMpL+2/cQrZPfnxoBqxdU3OKtNUSkkkbDUK1f/4LJD3CEgI5Nw== X-Received: by 2002:a7b:cd90:: with SMTP id y16mr9143590wmj.87.1627136064091; Sat, 24 Jul 2021 07:14:24 -0700 (PDT) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id o3sm35884737wrw.56.2021.07.24.07.14.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Jul 2021 07:14:23 -0700 (PDT) Message-Id: In-Reply-To: References: From: "ZheNing Hu via GitGitGadget" Date: Sat, 24 Jul 2021 14:14:17 +0000 Subject: [PATCH v3 1/5] [GSOC] ref-filter: add obj-type check in grab contents Fcc: Sent Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit MIME-Version: 1.0 To: git@vger.kernel.org Cc: Junio C Hamano , Christian Couder , Hariom Verma , Bagas Sanjaya , Jeff King , =?UTF-8?Q?=C3=86var_Arnfj=C3=B6r=C3=B0?= Bjarmason , Eric Sunshine , Philip Oakley , Jacob Keller , ZheNing Hu , ZheNing Hu Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: ZheNing Hu Only tag and commit objects use `grab_sub_body_contents()` to grab object contents in the current codebase. We want to teach the function to also handle blobs and trees to get their raw data, without parsing a blob (whose contents looks like a commit or a tag) incorrectly as a commit or a tag. So it's needed to pass a `struct expand_data *data` instread of only `void *buf` to both `grab_sub_body_contents()` and `grab_values()` to be able to check the object type. Skip the block of code that is specific to handling commits and tags early when the given object is of a wrong type to help later addition to handle other types of objects in this function. Mentored-by: Christian Couder Mentored-by: Hariom Verma Helped-by: Junio C Hamano Signed-off-by: ZheNing Hu --- ref-filter.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/ref-filter.c b/ref-filter.c index 4db0e40ff4c..5cee6512fba 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -1356,11 +1356,12 @@ static void append_lines(struct strbuf *out, const char *buf, unsigned long size } /* See grab_values */ -static void grab_sub_body_contents(struct atom_value *val, int deref, void *buf) +static void grab_sub_body_contents(struct atom_value *val, int deref, struct expand_data *data) { int i; const char *subpos = NULL, *bodypos = NULL, *sigpos = NULL; size_t sublen = 0, bodylen = 0, nonsiglen = 0, siglen = 0; + void *buf = data->content; for (i = 0; i < used_atom_cnt; i++) { struct used_atom *atom = &used_atom[i]; @@ -1371,10 +1372,13 @@ static void grab_sub_body_contents(struct atom_value *val, int deref, void *buf) continue; if (deref) name++; - if (strcmp(name, "body") && - !starts_with(name, "subject") && - !starts_with(name, "trailers") && - !starts_with(name, "contents")) + + if ((data->type != OBJ_TAG && + data->type != OBJ_COMMIT) || + (strcmp(name, "body") && + !starts_with(name, "subject") && + !starts_with(name, "trailers") && + !starts_with(name, "contents"))) continue; if (!subpos) find_subpos(buf, @@ -1438,17 +1442,19 @@ static void fill_missing_values(struct atom_value *val) * pointed at by the ref itself; otherwise it is the object the * ref (which is a tag) refers to. */ -static void grab_values(struct atom_value *val, int deref, struct object *obj, void *buf) +static void grab_values(struct atom_value *val, int deref, struct object *obj, struct expand_data *data) { + void *buf = data->content; + switch (obj->type) { case OBJ_TAG: grab_tag_values(val, deref, obj); - grab_sub_body_contents(val, deref, buf); + grab_sub_body_contents(val, deref, data); grab_person("tagger", val, deref, buf); break; case OBJ_COMMIT: grab_commit_values(val, deref, obj); - grab_sub_body_contents(val, deref, buf); + grab_sub_body_contents(val, deref, data); grab_person("author", val, deref, buf); grab_person("committer", val, deref, buf); break; @@ -1678,7 +1684,7 @@ static int get_object(struct ref_array_item *ref, int deref, struct object **obj return strbuf_addf_ret(err, -1, _("parse_object_buffer failed on %s for %s"), oid_to_hex(&oi->oid), ref->refname); } - grab_values(ref->value, deref, *obj, oi->content); + grab_values(ref->value, deref, *obj, oi); } grab_common_values(ref->value, deref, oi); -- gitgitgadget