From: "René Scharfe" <l.s.r@web.de>
To: Git List <git@vger.kernel.org>
Cc: "Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH] tree-walk: disallow overflowing modes
Date: Sat, 21 Jan 2023 10:36:09 +0100 [thread overview]
Message-ID: <d673fde7-7eb2-6306-86b6-1c1a4c988ee8@web.de> (raw)
When parsing tree entries, reject mode values that don't fit into an
unsigned int.
Signed-off-by: René Scharfe <l.s.r@web.de>
---
tree-walk.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tree-walk.c b/tree-walk.c
index 74f4d710e8..5e7bc38600 100644
--- a/tree-walk.c
+++ b/tree-walk.c
@@ -17,6 +17,8 @@ static const char *get_mode(const char *str, unsigned int *modep)
while ((c = *str++) != ' ') {
if (c < '0' || c > '7')
return NULL;
+ if ((mode << 3) >> 3 != mode)
+ return NULL;
mode = (mode << 3) + (c - '0');
}
*modep = mode;
--
2.39.1
next reply other threads:[~2023-01-21 9:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 9:36 René Scharfe [this message]
2023-01-22 7:50 ` [PATCH] tree-walk: disallow overflowing modes Jeff King
2023-01-22 10:03 ` René Scharfe
2023-01-22 16:36 ` Junio C Hamano
2023-01-22 22:02 ` Jeff King
2023-01-23 8:33 ` Ævar Arnfjörð Bjarmason
2023-01-24 18:53 ` René Scharfe
2023-01-24 20:44 ` Junio C Hamano
2023-01-26 11:36 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d673fde7-7eb2-6306-86b6-1c1a4c988ee8@web.de \
--to=l.s.r@web.de \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).