From: Paolo Bonzini <bonzini@gnu.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jonathan Tan <jonathantanmy@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 0/3] interpret-trailers: add --where, --if-exists, --if-missing
Date: Thu, 13 Jul 2017 01:42:38 +0200 [thread overview]
Message-ID: <d5e439c3-ba17-8efa-647d-eb64128064c8@gnu.org> (raw)
In-Reply-To: <xmqqmv89z2be.fsf@gitster.mtv.corp.google.com>
On 13/07/2017 01:02, Junio C Hamano wrote:
> Paolo Bonzini <bonzini@gnu.org> writes:
>
>> From: Paolo Bonzini <pbonzini@redhat.com>
>>
>> These options are useful to experiment with "git interpret-trailers"
>> without having to tinker with .gitconfig. It can also be useful in the
>> oddball case where you want a different placement for the trailer.
>>
>> Compared to "git -c", they are more easily discoverable, and also have
>> slightly different behavior because they override all trailer.*
>> configuration keys.
>
> I think this is a very good idea (we shouldn't have started the
> command only with the configurations; we rather should have done
> this first and then added configuration after that).
Actually we can do better: we can have --where only refer to
*subsequent* --trailer options. This will require more refactoring
(probably making a new struct that can be passed to process_trailers),
but the first two patches should be the same.
I'll have time for this only after vacation (so at the end of July), and
it's backwards-incompatible with this series. Reviews are welcome
anyway. :)
Thanks for encouraging me. It's always a pleasure when I can scratch my
git itches!
Paolo
> Looking forward to reviewing them, but I am cutting a maint release
> now, so it may have to wait a bit.
>
> Thanks.
>
>>
>> Paolo
>>
>> v1->v2: support --no-* options, minor code fixes
>>
>> Paolo Bonzini (3):
>> trailers: create struct trailer_opts
>> trailers: export action enums and corresponding lookup functions
>> interpret-trailers: add options for actions
>>
>> Documentation/git-interpret-trailers.txt | 16 +++++
>> builtin/interpret-trailers.c | 44 ++++++++++---
>> t/t7513-interpret-trailers.sh | 66 ++++++++++++++++++++
>> trailer.c | 102 ++++++++++++++++++++-----------
>> trailer.h | 35 ++++++++++-
>> 5 files changed, 218 insertions(+), 45 deletions(-)
>
prev parent reply other threads:[~2017-07-12 23:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 22:21 [PATCH v2 0/3] interpret-trailers: add --where, --if-exists, --if-missing Paolo Bonzini
2017-07-12 22:21 ` [PATCH v2 1/3] trailers: create struct trailer_opts Paolo Bonzini
2017-07-12 22:21 ` [PATCH v2 2/3] trailers: export action enums and corresponding lookup functions Paolo Bonzini
2017-07-13 6:00 ` Christian Couder
2017-07-17 21:13 ` Junio C Hamano
2017-07-12 22:21 ` [PATCH v2 3/3] interpret-trailers: add options for actions Paolo Bonzini
2017-07-12 23:02 ` [PATCH v2 0/3] interpret-trailers: add --where, --if-exists, --if-missing Junio C Hamano
2017-07-12 23:42 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5e439c3-ba17-8efa-647d-eb64128064c8@gnu.org \
--to=bonzini@gnu.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).