list mirror (unofficial, one of many)
 help / color / mirror / Atom feed
From: Ramsay Jones <>
Cc: Junio C Hamano <>,
	GIT Mailing-list <>
Subject: [PATCH] sequencer: mark a file-local symbol as static
Date: Tue, 12 Mar 2019 02:53:46 +0000
Message-ID: <> (raw)

Signed-off-by: Ramsay Jones <>

Hi Denton,

If you need to re-roll your 'dl/merge-cleanup-scissors-fix' branch,
could you please squash this into the relevant patch (commit 9bcdf520cb
("sequencer.c: define get_config_from_cleanup", 2019-03-10)).

I note also, that the get_config_from_cleanup() function is not
called outside of sequencer.c, so that this function could also
be marked static (and remove the extern declaration from the
header file) if there are no plans for future callers.


Ramsay Jones

 sequencer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sequencer.c b/sequencer.c
index 19d1279fa8..833017eb2d 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -166,7 +166,7 @@ struct cleanup_config_mapping {
 /* note that we assume that cleanup_config_mapping[0] contains the default settings */
-struct cleanup_config_mapping cleanup_config_mappings[] = {
+static struct cleanup_config_mapping cleanup_config_mappings[] = {

             reply	other threads:[~2019-03-12  2:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12  2:53 Ramsay Jones [this message]
2019-03-12  2:58 ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ \
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
 note: .onion URLs require Tor:

code repositories for the project(s) associated with this inbox:

AGPL code for this site: git clone