From: Derrick Stolee <stolee@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Derrick Stolee <dstolee@microsoft.com>,
git@vger.kernel.org, git@jeffhostetler.com
Subject: Re: [PATCH v2 1/5] test-list-objects: List a subset of object ids
Date: Sat, 7 Oct 2017 15:12:08 -0400 [thread overview]
Message-ID: <d5b3107f-76ec-8e8c-d7f5-d0f1ec75b1c9@gmail.com> (raw)
In-Reply-To: <20171006141128.rkuhd4m7hp2f7vvx@sigill.intra.peff.net>
On 10/6/2017 10:11 AM, Jeff King wrote:
> On Thu, Oct 05, 2017 at 08:39:42AM -0400, Derrick Stolee wrote:
>> I'll run some perf numbers for these commands you recommend, and also see if
>> I can replicate some of the pain points that triggered this change using the
>> Linux repo.
>
> Thanks!
>
> -Peff
>
In my local copy, I added a test to p4211-line-log.sh that runs "git log
--raw -r" and tested it on three copies of the Linux repo. In order,
they have 1 packfile (0 loose), 24 packfiles (0 loose), and 23 packfiles
(~324,000 loose).
4211.6: git log --raw -r 43.34(42.62+0.65) 40.47(40.16+0.27) -6.6%
4211.6: git log --raw -r 88.77(86.54+2.12) 82.44(81.87+0.52) -7.1%
4211.6: git log --raw -r 108.86(103.97+4.81) 103.92(100.63+3.19) -4.5%
We have moderate performance gains for this command, despite the command
doing many more things than just checking abbreviations.
I plan to re-roll my patch on Monday including the following feedback items:
* Remove test-list-objects and test-abbrev in favor of a new "git log"
performance test.
* Fix binary search overflow error.
* Check response from open_pack_index(p) in find_abbrev_len_for_pack().
I plan to return without failure on non-zero result, which results in
no failure on a bad pack and the abbreviation length will be the
minimum required among all valid packs. (Thanks Stefan!)
I made note of a few things, but will not include them in my re-roll.
I'll revisit them later if they are valuable:
- nth_packed_object_sha1() could be simplified in
find_abbrev_len_for_pack().
- Teach 'cat-file' to --batch-check='%(objectsize:short)'. (Peff already
included a patch, perhaps that could be reviewed separately.)
- Ramsay caught my lack of "static" in test-list-objects.c, but that
file will be removed in the next patch. I'll make sure to use "static"
in the future.
I'm not re-rolling immediately to allow for some extra review over the
weekend, if anyone is so inclined.
Thanks,
-Stolee
next prev parent reply other threads:[~2017-10-07 19:12 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 9:54 [PATCH v2 0/5] Improve abbreviation disambiguation Derrick Stolee
2017-09-25 9:54 ` [PATCH v2 1/5] test-list-objects: List a subset of object ids Derrick Stolee
2017-09-26 9:24 ` Junio C Hamano
2017-10-05 8:42 ` Jeff King
2017-10-05 9:48 ` Junio C Hamano
2017-10-05 10:00 ` Jeff King
2017-10-05 10:16 ` Junio C Hamano
2017-10-05 12:39 ` Derrick Stolee
2017-10-06 14:11 ` Jeff King
2017-10-07 19:12 ` Derrick Stolee [this message]
2017-10-07 19:33 ` Jeff King
2017-10-08 1:46 ` Junio C Hamano
2017-09-25 9:54 ` [PATCH v2 2/5] p0008-abbrev.sh: Test find_unique_abbrev() perf Derrick Stolee
2017-09-26 9:27 ` Junio C Hamano
2017-10-05 8:55 ` Jeff King
2017-10-05 8:57 ` Jeff King
2017-09-25 9:54 ` [PATCH v2 3/5] sha1_name: Unroll len loop in find_unique_abbrev_r Derrick Stolee
2017-09-25 9:54 ` [PATCH v2 4/5] sha1_name: Parse less while finding common prefix Derrick Stolee
2017-09-25 23:42 ` Stefan Beller
2017-10-02 14:52 ` Derrick Stolee
2017-09-25 9:54 ` [PATCH v2 5/5] sha1_name: Minimize OID comparisons during disambiguation Derrick Stolee
2017-10-02 14:56 ` [PATCH v3 0/5] Improve abbreviation disambituation Derrick Stolee
2017-10-05 9:49 ` Jeff King
2017-10-02 14:56 ` [PATCH v3 1/5] test-list-objects: List a subset of object ids Derrick Stolee
2017-10-03 4:16 ` Junio C Hamano
2017-10-02 14:56 ` [PATCH v3 2/5] p0008-abbrev.sh: Test find_unique_abbrev() perf Derrick Stolee
2017-10-02 14:56 ` [PATCH v3 3/5] sha1_name: Unroll len loop in find_unique_abbrev_r Derrick Stolee
2017-10-03 10:49 ` Junio C Hamano
2017-10-03 11:26 ` Derrick Stolee
2017-10-04 6:10 ` Junio C Hamano
2017-10-04 13:06 ` Derrick Stolee
2017-10-04 6:07 ` Junio C Hamano
2017-10-04 13:19 ` Derrick Stolee
2017-10-05 1:26 ` Junio C Hamano
2017-10-05 9:13 ` Jeff King
2017-10-05 9:50 ` Junio C Hamano
2017-10-02 14:56 ` [PATCH v3 4/5] sha1_name: Parse less while finding common prefix Derrick Stolee
2017-10-04 6:14 ` Junio C Hamano
2017-10-02 14:56 ` [PATCH v3 5/5] sha1_name: Minimize OID comparisons during disambiguation Derrick Stolee
2017-10-03 15:55 ` Stefan Beller
2017-10-03 17:05 ` Derrick Stolee
2017-10-05 9:44 ` Jeff King
2017-10-06 13:52 ` [PATCH] cleanup: fix possible overflow errors in binary search Derrick Stolee
2017-10-06 14:18 ` Jeff King
2017-10-06 14:41 ` Derrick Stolee
2017-10-08 18:29 ` [PATCH v2] " Derrick Stolee
2017-10-09 13:33 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5b3107f-76ec-8e8c-d7f5-d0f1ec75b1c9@gmail.com \
--to=stolee@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).