From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 56C1D1F462 for ; Mon, 17 Jun 2019 01:14:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727394AbfFQBOK (ORCPT ); Sun, 16 Jun 2019 21:14:10 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:37466 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727235AbfFQBOK (ORCPT ); Sun, 16 Jun 2019 21:14:10 -0400 Received: by mail-qk1-f195.google.com with SMTP id d15so5241366qkl.4 for ; Sun, 16 Jun 2019 18:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6pVnNf8vsYMC6Xj/RIvFXWr2mHOneFXUqpgU0yiRsHk=; b=HOFafvRitqbvJ6ybtquKmasF1E3S/YmYjbmq4YOPXK0wbem7BexwL64sIb5WKqwMny spen6q+Kg8NIuTB3SSyyjQool0LRzuaWjkgpbL2DnJsnmJaO1UfpWNFzqf5Z9BKzKOYq 59hopK5vV0/2nSccXHZVD/0IJIq/rcCR8ZWzPZDRKmQ0bM01O2GBUXNNqhfj84qRJMK+ Zt3or89YrTX6p6/6GGhpjWgeXwCZ7Ukf3FHIqvZksbhgMGZWDY5uZKh3BVnL9y5P0+Af igIlz6k2+VuPtIqeG/U37Ex7MRMpBXYUMInOFh421vb9Ed/bV43WPJonSYPWiMIVdAiI XAEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6pVnNf8vsYMC6Xj/RIvFXWr2mHOneFXUqpgU0yiRsHk=; b=mOYdJdtxbhyiMCRp9Nh4wyrFOUTLZg0v+u9KO1MAuk6RjlFzGEW9hfyzrqCUtSjHiD 1+68YLjxwxVP5INLAp4gbIw37iwTCfZ/hrQANhGzjJXVkhhRu5nWmpsvhDQQQ0xZ6NQD L84pfg3wtKSF5dMtmplwdGJr3bCyDMvBLwFkBAEZqdcBv7LA3j4RDBjvzQ5TlRALQODA ocunKe1O2l0bA+hh0l2tqmb3753UvypAs/cyKfW/odb4x3XVwg4EyG02+/qNnOF7X4kc Dxz4DqEO1NfDTXnXb26HTaavckYX+hTvxVipnbfTHLAgQQ6/Thf9OSDPhrGQbT73mrnK PUAg== X-Gm-Message-State: APjAAAWz0TWT6h6y1TOzIF/5tuSLxOgy+27rq1vJl7WTlO0WE1m9sFd3 fTEpHSGh6kD/vp1CV17HL5Y= X-Google-Smtp-Source: APXvYqw53NsEux9bx9BvcHClScCJlvzGZxmcMi6Ss70NW4RbmCGl30m9SjX50meyFp7M9trIUrE05g== X-Received: by 2002:ae9:eb53:: with SMTP id b80mr58155112qkg.172.1560734049527; Sun, 16 Jun 2019 18:14:09 -0700 (PDT) Received: from [10.0.1.13] ([98.122.173.75]) by smtp.gmail.com with ESMTPSA id s11sm6264049qte.49.2019.06.16.18.14.07 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Sun, 16 Jun 2019 18:14:08 -0700 (PDT) Subject: Re: [PATCH 2/2] use COPY_ARRAY for copying arrays To: =?UTF-8?Q?Ren=c3=a9_Scharfe?= , Git Mailing List Cc: Junio C Hamano References: From: Derrick Stolee Message-ID: Date: Sun, 16 Jun 2019 21:14:06 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:67.0) Gecko/20100101 Thunderbird/67.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 6/15/2019 2:36 PM, René Scharfe wrote: > Convert calls of memcpy(3) to use COPY_ARRAY, which shortens and > simplifies the code a bit. These changes do look simpler. Thanks! > Patch generated by Coccinelle and contrib/coccinelle/array.cocci. And this auto-generation is particularly useful! > > Signed-off-by: Rene Scharfe > --- > fast-import.c | 2 +- > kwset.c | 2 +- > packfile.c | 6 +++--- > pretty.c | 4 ++-- > 4 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/kwset.c b/kwset.c > index 4fb6455aca..090ffcafa2 100644 > --- a/kwset.c > +++ b/kwset.c > @@ -475,7 +475,7 @@ kwsprep (kwset_t kws) > for (i = 0; i < NCHAR; ++i) > kwset->next[i] = next[U(trans[i])]; > else > - memcpy(kwset->next, next, NCHAR * sizeof(struct trie *)); > + COPY_ARRAY(kwset->next, next, NCHAR); I was unfamiliar with kwset.c, so I took a look and noticed that it was adapted from GNU grep, so this change takes us even farther from the original source (and closer to Git source conventions). I think this is the right thing to do, but thought I'd point it out in case anyone thought differently. Both patches LGTM. Thanks, -Stolee