git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>,
	Derrick Stolee <dstolee@microsoft.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] midx.c: mark a file-local symbol as static
Date: Mon, 17 Sep 2018 16:11:59 -0400	[thread overview]
Message-ID: <d4b88c9e-9d02-f361-922e-f85caf3994e1@gmail.com> (raw)
In-Reply-To: <63d480c7-0312-3b1d-59bc-7b9996facea0@ramsayjones.plus.com>

On 9/14/2018 7:26 PM, Ramsay Jones wrote:
> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Derrick,
>
> If you need to re-roll your 'ds/multi-pack-verify' branch, could you
> please squash this into the relevant patch (commit 64cbf3df21,
> "multi-pack-index: add 'verify' verb", 2018-09-13).
>
> [noticed by sparse].
>
> Thanks.
>
> ATB,
> Ramsay Jones

Thanks for catching this, Ramsay. Sorry for the mistake.

ds/multi-pack-verify is currently queued for 'next', so I wasn't 
planning on sending another version.

Junio, could you add this commit to the tip, or squash it into 64cbf3df2 
"multi-pack-index: add 'verify' verb"?

Thanks,
-Stolee

>
>   midx.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/midx.c b/midx.c
> index 4d4c930522..713d6f9dde 100644
> --- a/midx.c
> +++ b/midx.c
> @@ -926,7 +926,7 @@ void clear_midx_file(const char *object_dir)
>   	free(midx);
>   }
>   
> -int verify_midx_error;
> +static int verify_midx_error;
>   
>   static void midx_report(const char *fmt, ...)
>   {


  reply	other threads:[~2018-09-17 20:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-14 23:26 [PATCH] midx.c: mark a file-local symbol as static Ramsay Jones
2018-09-17 20:11 ` Derrick Stolee [this message]
2018-09-17 20:44   ` Junio C Hamano
2018-09-17 20:47   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4b88c9e-9d02-f361-922e-f85caf3994e1@gmail.com \
    --to=stolee@gmail.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).