From: Konstantinos Dalamagkidis <konstantinos@dalamagkidis.info>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: git-send-email does not use conditional configuration
Date: Wed, 11 Sep 2019 18:58:26 +0200 [thread overview]
Message-ID: <d4717b7f-b7a4-208b-6b83-7993b6bd7886@dalamagkidis.info> (raw)
In-Reply-To: <20190911140833.GA13916@sigill.intra.peff.net>
On 9/11/19 4:08 PM, Jeff King wrote:
> On Wed, Sep 11, 2019 at 08:14:45AM +0200, Konstantinos Dalamagkidis wrote:
>
>> In my git configuration, I have an includeif section for work
>> related repositories that configures the user and sendemail
>> sections.
>
> What kind of includeIf are you using? Does it work with an
> unconditional include? This seems to work for me:
>
> $ git config --global include.path one
> $ git config --file ~/one sendemail.smtpserver one.example.com
> $ git send-email --dry-run -1 --to nobody | grep ^Server
> Server: one.example.com
>
> $ git config --global includeIf.gitdir:$PWD/.path two
> $ git config --file ~/two sendemail.smtpserver two.example.com
> $ git send-email --dry-run -1 --to nobody | grep ^Server
> Server: two.example.com
>
> I.e. both unconditional and gitdir includes work for me. If you do
> something similar, what output do you get?
I am using "includeIf.gitdir:/work". I tried to reproduce it at my home
workstation where I have the exact same configuration, but in the
beginning I couldn't. Then I realized, that at work the /work folder is
actually a symlink to a different directory. When I did the same at
home, I could reproduce the issue:
% pwd
/work/repo
% git send-email --dry-run -1 --to nobody | grep ^From
From: Konstantinos Dalamagkidis <work-email@example.com>
% cd ../repo-symlink
% git send-email --dry-run -1 --to nobody | grep ^From
From: Konstantinos Dalamagkidis <personal-email@example.com>
% realpath .
/home/dalamagkidis/tmp/repo
It appears that git-config and git-send-email parse the gitdir slightly
differently when it comes to symlinks. More specifically git-send-email
uses the realpath of the repository to determine which configuration to
use. It also explains why nobody came across this problem before.
Rgds
Konstantinos
next prev parent reply other threads:[~2019-09-11 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 6:14 git-send-email does not use conditional configuration Konstantinos Dalamagkidis
2019-09-11 14:08 ` Jeff King
2019-09-11 16:58 ` Konstantinos Dalamagkidis [this message]
2019-09-11 18:05 ` Git.pm normalizes $GIT_DIR, was " Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4717b7f-b7a4-208b-6b83-7993b6bd7886@dalamagkidis.info \
--to=konstantinos@dalamagkidis.info \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).