From: "마누엘 via GitGitGadget" <gitgitgadget@gmail.com> To: git@vger.kernel.org Cc: "Jeff King" <peff@peff.net>, "Johannes Schindelin" <johannes.schindelin@gmx.de>, 마누엘 <nalla@hamal.uberspace.de> Subject: [PATCH v2 2/2] Explicitly `fflush` stdout before expecting interactive input Date: Fri, 10 Apr 2020 11:27:51 +0000 [thread overview] Message-ID: <d3949e42004f31e8741fad08352f782b4b8536eb.1586518072.git.gitgitgadget@gmail.com> (raw) In-Reply-To: <pull.755.v2.git.git.1586518072.gitgitgadget@gmail.com> From: =?UTF-8?q?=EB=A7=88=EB=88=84=EC=97=98?= <nalla@hamal.uberspace.de> At least one interactive command writes a prompt to `stdout` and then reads user input on `stdin`: `git clean --interactive`. If the prompt is left in the buffer, the user will not realize the program is waiting for their input. So let's just flush `stdout` before reading the user's input. Signed-off-by: 마누엘 <nalla@hamal.uberspace.de> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- prompt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/prompt.c b/prompt.c index 098dcfb7cf9..5ded21a017f 100644 --- a/prompt.c +++ b/prompt.c @@ -77,8 +77,10 @@ char *git_prompt(const char *prompt, int flags) int git_read_line_interactively(struct strbuf *line) { - int ret = strbuf_getline_lf(line, stdin); + int ret; + fflush(stdout); + ret = strbuf_getline_lf(line, stdin); if (ret != EOF) strbuf_trim_trailing_newline(line); -- gitgitgadget
next prev parent reply other threads:[~2020-04-10 11:27 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-08 19:33 [PATCH] clean: explicitly `fflush` stdout Johannes Schindelin via GitGitGadget 2020-04-08 20:14 ` Jeff King 2020-04-08 21:51 ` Junio C Hamano 2020-04-08 22:38 ` Jeff King 2020-04-10 14:03 ` Johannes Schindelin 2020-04-10 11:27 ` [PATCH v2 0/2] Explicitly fflush stdout in git clean Johannes Schindelin via GitGitGadget 2020-04-10 11:27 ` [PATCH v2 1/2] Refactor code asking the user for input interactively Johannes Schindelin via GitGitGadget 2020-04-10 12:27 ` Derrick Stolee 2020-04-10 14:01 ` Johannes Schindelin 2020-04-10 15:07 ` Jeff King 2020-04-10 17:44 ` Junio C Hamano 2020-04-10 11:27 ` 마누엘 via GitGitGadget [this message] 2020-04-10 12:28 ` [PATCH v2 2/2] Explicitly `fflush` stdout before expecting interactive input Derrick Stolee 2020-04-10 18:16 ` [PATCH v3 0/2] Explicitly fflush stdout in git clean Johannes Schindelin via GitGitGadget 2020-04-10 18:16 ` [PATCH v3 1/2] Refactor code asking the user for input interactively Johannes Schindelin via GitGitGadget 2020-04-10 18:16 ` [PATCH v3 2/2] Explicitly `fflush` stdout before expecting interactive input 마누엘 via GitGitGadget
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d3949e42004f31e8741fad08352f782b4b8536eb.1586518072.git.gitgitgadget@gmail.com \ --to=gitgitgadget@gmail.com \ --cc=git@vger.kernel.org \ --cc=johannes.schindelin@gmx.de \ --cc=nalla@hamal.uberspace.de \ --cc=peff@peff.net \ --subject='Re: [PATCH v2 2/2] Explicitly `fflush` stdout before expecting interactive input' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).