From: Michele Locati <michele@locati.it>
To: Ian Campbell <ijc@hellion.org.uk>, Jeff King <peff@peff.net>,
CB Bailey <charles@hashpling.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] filter-branch: use printf instead of echo -e
Date: Tue, 20 Mar 2018 11:21:54 +0100 [thread overview]
Message-ID: <d2bf28a9-ae79-9046-22f4-ceac502882f6@locati.it> (raw)
In-Reply-To: <1521539621.2474.60.camel@hellion.org.uk>
Il 20/03/2018 10:53, Ian Campbell ha scritto:
> On Tue, 2018-03-20 at 00:22 -0400, Jeff King wrote:
>> Author cc'd in case there's something more interesting going on.
>
> That code was written years ago, if I had a good reason at the time
> I've forgotten what it was and I can't think of a fresh one now.
> Switching to printf seems like a reasonable thing to do.
>
> Perhaps switch the remaining `/bin/echo` (there are two without `-e`)
> uses to just `echo` for consistency with the rest of the file?
>
> Ian.
>
Thanks for reply, Ian.
Charles already suggested to replace /bin/echo with echo, and I already
updated the patch accordingly: see
https://marc.info/?l=git&m=152147479517707&w=2
Junio already queued that PATCH-v2.
--
Michele
next prev parent reply other threads:[~2018-03-20 10:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 14:49 [PATCH] filter-branch: use printf instead of echo -e Michele Locati
2018-03-19 15:39 ` CB Bailey
2018-03-20 4:22 ` Jeff King
2018-03-20 9:53 ` Ian Campbell
2018-03-20 10:21 ` Michele Locati [this message]
2018-03-19 15:52 ` [PATCH v2] " Michele Locati
2018-03-19 18:00 ` Junio C Hamano
2018-03-21 21:50 ` Johannes Schindelin
2018-03-22 13:40 ` Michele Locati
2018-03-23 9:35 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2bf28a9-ae79-9046-22f4-ceac502882f6@locati.it \
--to=michele@locati.it \
--cc=charles@hashpling.org \
--cc=git@vger.kernel.org \
--cc=ijc@hellion.org.uk \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).