From: Taylor Blau <me@ttaylorr.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH v2 0/4] leak tests: mark remaining tests leak-free as such
Date: Mon, 28 Aug 2023 18:52:52 -0400 [thread overview]
Message-ID: <cover.1693263171.git.me@ttaylorr.com> (raw)
In-Reply-To: <cover.1692902414.git.me@ttaylorr.com>
Here is a reroll of my (I guess now mine and Peff's!) series to update
our test scripts to accurately mark which ones are leak-free.
This is mostly unchanged from the previous round, modulo cleaning up the
first (now second) patch's message, and inserting a new patch from Peff
at the beginning to ignore noisy LSan output.
Thanks in advance for your review!
Jeff King (1):
test-lib: ignore uninteresting LSan output
Taylor Blau (3):
leak tests: mark a handful of tests as leak-free
leak tests: mark t3321-notes-stripspace.sh as leak-free
leak tests: mark t5583-push-branches.sh as leak-free
t/t3321-notes-stripspace.sh | 1 +
t/t5571-pre-push-hook.sh | 1 +
t/t5583-push-branches.sh | 1 +
t/t7516-commit-races.sh | 2 ++
t/test-lib.sh | 1 +
5 files changed, 6 insertions(+)
Range-diff against v1:
-: ---------- > 1: 7dd42212c0 test-lib: ignore uninteresting LSan output
1: b1711c4c81 ! 2: 164f37cade leak tests: mark a handful of tests as leak-free
@@ Commit message
'ab/mark-leak-free-tests', 2021-10-25), a handful of tests in the suite
were marked as leak-free.
- As far as I can tell, each patch from that series ran tests from a
- handful of subject areas, such as "some ls-files tests", or "all trace2
- tests". This left some gaps in which tests had and hadn't been audited
- to be leak-free.
+ Since then, a handful of tests have become leak-free due to changes like
- This patch closes those gaps by exporting TEST_PASSES_SANITIZE_LEAK=true
- before sourcing t/test-lib.sh on most remaining leak-free tests. This
- list was compiled by doing:
+ - 861c56f6f9 (branch: fix a leak in setup_tracking, 2023-06-11), and
+ - 866b43e644 (do_read_index(): always mark index as initialized unless
+ erroring out, 2023-06-29)
+
+ , but weren't updated at the time to mark themselves as such. This leads
+ to test "failures" when running:
$ make SANITIZE=leak
- $ make \
+ $ make -C t \
GIT_TEST_PASSING_SANITIZE_LEAK=check \
GIT_TEST_SANITIZE_LEAK_LOG=true \
GIT_TEST_OPTS=-vi test
- and looking through the list of failing tests in the output.
+ This patch closes those gaps by exporting TEST_PASSES_SANITIZE_LEAK=true
+ before sourcing t/test-lib.sh on most remaining leak-free tests.
There are a couple of other tests which are similarly leak-free, but not
included in the list of tests touched by this patch. The remaining tests
will be addressed in the subsequent two patches.
+ Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
## t/t5571-pre-push-hook.sh ##
2: cfeca88942 = 3: 116555fc02 leak tests: mark t3321-notes-stripspace.sh as leak-free
3: 4011eb6a8b = 4: a16a0b2cac leak tests: mark t5583-push-branches.sh as leak-free
--
2.42.0.49.g03c54e21ee
next prev parent reply other threads:[~2023-08-28 22:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 18:40 [PATCH 0/3] leak tests: mark remaining tests leak-free as such Taylor Blau
2023-08-24 18:40 ` [PATCH 1/3] leak tests: mark a handful of tests as leak-free Taylor Blau
2023-08-24 21:02 ` Jeff King
2023-08-25 19:05 ` Taylor Blau
2023-08-25 20:38 ` Jeff King
2023-08-28 18:24 ` Junio C Hamano
2023-08-28 18:37 ` [PATCH] test-lib: ignore uninteresting LSan output Jeff King
2023-08-24 18:40 ` [PATCH 2/3] leak tests: mark t3321-notes-stripspace.sh as leak-free Taylor Blau
2023-08-24 18:40 ` [PATCH 3/3] leak tests: mark t5583-push-branches.sh " Taylor Blau
2023-08-24 18:50 ` [PATCH 0/3] leak tests: mark remaining tests leak-free as such Junio C Hamano
2023-08-24 20:50 ` Jeff King
2023-08-24 20:54 ` Jeff King
2023-08-25 19:08 ` Taylor Blau
2023-08-25 20:35 ` Jeff King
2023-08-28 22:52 ` Taylor Blau [this message]
2023-08-28 22:52 ` [PATCH v2 1/4] test-lib: ignore uninteresting LSan output Taylor Blau
2023-08-28 22:52 ` [PATCH v2 2/4] leak tests: mark a handful of tests as leak-free Taylor Blau
2023-08-28 22:53 ` [PATCH v2 3/4] leak tests: mark t3321-notes-stripspace.sh " Taylor Blau
2023-08-28 22:53 ` [PATCH v2 4/4] leak tests: mark t5583-push-branches.sh " Taylor Blau
2023-08-29 1:00 ` [PATCH v2 0/4] leak tests: mark remaining tests leak-free as such Jeff King
2023-08-29 16:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1693263171.git.me@ttaylorr.com \
--to=me@ttaylorr.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).