From: Patrick Steinhardt <ps@pks.im>
To: git@vger.kernel.org
Cc: Taylor Blau <me@ttaylorr.com>, Derrick Stolee <stolee@gmail.com>,
Christian Couder <christian.couder@gmail.com>
Subject: [PATCH v3 0/2] fetch: speed up mirror-fetches with many refs
Date: Thu, 10 Feb 2022 13:28:01 +0100 [thread overview]
Message-ID: <cover.1644495978.git.ps@pks.im> (raw)
In-Reply-To: <cover.1643806143.git.ps@pks.im>
[-- Attachment #1: Type: text/plain, Size: 4413 bytes --]
Hi,
this is the third version of my patch series which aimn to speed up
mirror-fetches in repos with huge amounts of refs. Again, the only
change compared to v2 is a change in commit messages: Chris has rightly
pointed out that the benchmarks were a bit confusing, so I've updated
them to hopefully be less so.
Thanks for your feedback!
Patrick
Patrick Steinhardt (2):
fetch-pack: use commit-graph when computing cutoff
fetch: skip computing output width when not printing anything
builtin/fetch.c | 8 ++++++--
fetch-pack.c | 28 ++++++++++++++++------------
2 files changed, 22 insertions(+), 14 deletions(-)
Range-diff against v2:
1: 6fac914f0f ! 1: 077d06764c fetch-pack: use commit-graph when computing cutoff
@@ Commit message
the commit-graph first, which is a lot more efficient.
Benchmarks in a repository with about 2,1 million refs and an up-to-date
- commit-graph show a 20% speedup when mirror-fetching:
+ commit-graph show an almost 20% speedup when mirror-fetching:
- Benchmark 1: git fetch --atomic +refs/*:refs/* (v2.35.0)
- Time (mean ± σ): 75.264 s ± 1.115 s [User: 68.199 s, System: 10.094 s]
- Range (min … max): 74.145 s … 76.862 s 5 runs
+ Benchmark 1: git fetch +refs/*:refs/* (v2.35.0)
+ Time (mean ± σ): 115.587 s ± 2.009 s [User: 109.874 s, System: 11.305 s]
+ Range (min … max): 113.584 s … 118.820 s 5 runs
- Benchmark 2: git fetch --atomic +refs/*:refs/* (HEAD)
- Time (mean ± σ): 62.350 s ± 0.854 s [User: 55.412 s, System: 9.976 s]
- Range (min … max): 61.224 s … 63.216 s 5 runs
+ Benchmark 2: git fetch +refs/*:refs/* (HEAD)
+ Time (mean ± σ): 96.859 s ± 0.624 s [User: 91.948 s, System: 10.980 s]
+ Range (min … max): 96.180 s … 97.875 s 5 runs
Summary
- 'git fetch --atomic +refs/*:refs/* (HEAD)' ran
- 1.21 ± 0.02 times faster than 'git fetch --atomic +refs/*:refs/* (v2.35.0)'
+ 'git fetch +refs/*:refs/* (HEAD)' ran
+ 1.19 ± 0.02 times faster than 'git fetch +refs/*:refs/* (v2.35.0)'
Signed-off-by: Patrick Steinhardt <ps@pks.im>
2: 4b9bbcf795 ! 2: ef1fd07be5 fetch: skip computing output width when not printing anything
@@ Commit message
don't print the summary, but still compute the length.
Skip computing the summary width when the user asked for us to be quiet.
- This gives us a small speedup of nearly 10% when doing a dry-run
- mirror-fetch in a repository with thousands of references being updated:
+ This gives us a speedup of nearly 10% when doing a mirror-fetch in a
+ repository with thousands of references being updated:
- Benchmark 1: git fetch --prune --dry-run +refs/*:refs/* (HEAD~)
- Time (mean ± σ): 34.048 s ± 0.233 s [User: 30.739 s, System: 4.640 s]
- Range (min … max): 33.785 s … 34.296 s 5 runs
+ Benchmark 1: git fetch --quiet +refs/*:refs/* (HEAD~)
+ Time (mean ± σ): 96.078 s ± 0.508 s [User: 91.378 s, System: 10.870 s]
+ Range (min … max): 95.449 s … 96.760 s 5 runs
- Benchmark 2: git fetch --prune --dry-run +refs/*:refs/* (HEAD)
- Time (mean ± σ): 30.768 s ± 0.287 s [User: 27.534 s, System: 4.565 s]
- Range (min … max): 30.432 s … 31.181 s 5 runs
+ Benchmark 2: git fetch --quiet +refs/*:refs/* (HEAD)
+ Time (mean ± σ): 88.214 s ± 0.192 s [User: 83.274 s, System: 10.978 s]
+ Range (min … max): 87.998 s … 88.446 s 5 runs
Summary
- 'git fetch --prune --dry-run +refs/*:refs/* (HEAD)' ran
- 1.11 ± 0.01 times faster than 'git fetch --prune --dry-run +refs/*:refs/* (HEAD~)'
+ 'git fetch --quiet +refs/*:refs/* (HEAD)' ran
+ 1.09 ± 0.01 times faster than 'git fetch --quiet +refs/*:refs/* (HEAD~)'
Signed-off-by: Patrick Steinhardt <ps@pks.im>
--
2.35.1
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-02-10 12:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 10:15 [PATCH 0/2] fetch: speed up mirror-fetches with many refs Patrick Steinhardt
2022-01-28 10:17 ` [PATCH 1/2] fetch-pack: use commit-graph when computing cutoff Patrick Steinhardt
2022-01-31 22:53 ` Taylor Blau
2022-02-02 12:46 ` Patrick Steinhardt
2022-01-28 10:19 ` [PATCH 2/2] fetch: skip computing output width when not printing anything Patrick Steinhardt
2022-02-02 12:51 ` [PATCH v2 0/2] fetch: speed up mirror-fetches with many refs Patrick Steinhardt
2022-02-02 12:51 ` [PATCH v2 1/2] fetch-pack: use commit-graph when computing cutoff Patrick Steinhardt
2022-02-09 18:01 ` Christian Couder
2022-02-10 11:43 ` Patrick Steinhardt
2022-02-02 12:51 ` [PATCH v2 2/2] fetch: skip computing output width when not printing anything Patrick Steinhardt
2022-02-09 18:10 ` Christian Couder
2022-02-10 12:23 ` Patrick Steinhardt
2022-02-10 12:28 ` Patrick Steinhardt [this message]
2022-02-10 12:28 ` [PATCH v3 1/2] fetch-pack: use commit-graph when computing cutoff Patrick Steinhardt
2022-02-10 12:28 ` [PATCH v3 2/2] fetch: skip computing output width when not printing anything Patrick Steinhardt
2022-02-10 18:04 ` [PATCH v3 0/2] fetch: speed up mirror-fetches with many refs Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1644495978.git.ps@pks.im \
--to=ps@pks.im \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).