From: Patrick Steinhardt <ps@pks.im> To: git@vger.kernel.org Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>, "Jeff King" <peff@peff.net> Subject: [PATCH v2 0/2] git: support separate arg for `--config-env`'s value Date: Thu, 29 Apr 2021 14:55:25 +0200 [thread overview] Message-ID: <cover.1619700731.git.ps@pks.im> (raw) In-Reply-To: <cover.1618847606.git.ps@pks.im> [-- Attachment #1: Type: text/plain, Size: 1435 bytes --] Hi, this is the second version of this series fixing inconsistencies with the `--config-env` parameter. It's only got a single change compared to v1, which is to replace `test_i18ngrep` with `grep` as pointed out by Ævar. Patrick Patrick Steinhardt (2): git.txt: fix synopsis of `--config-env` missing the equals sign git: support separate arg for `--config-env`'s value Documentation/git.txt | 2 +- git.c | 8 ++++++++ t/t1300-config.sh | 15 ++++++++++++++- 3 files changed, 23 insertions(+), 2 deletions(-) Range-diff against v1: 1: 08049f3b10 = 1: 08049f3b10 git.txt: fix synopsis of `--config-env` missing the equals sign 2: d52db89bc2 ! 2: 5264fb6fa7 git: support separate arg for `--config-env`'s value @@ t/t1300-config.sh: test_expect_success 'git --config-env=key=envvar support' ' +test_expect_success 'git --config-env with missing value' ' + test_must_fail env ENVVAR=value git --config-env 2>error && -+ test_i18ngrep "no config key given for --config-env" error && ++ grep "no config key given for --config-env" error && + test_must_fail env ENVVAR=value git --config-env config core.name 2>error && -+ test_i18ngrep "invalid config format: config" error ++ grep "invalid config format: config" error +' + test_expect_success 'git --config-env fails with invalid parameters' ' -- 2.31.1 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-04-29 12:53 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-19 15:56 [PATCH " Patrick Steinhardt 2021-04-19 15:56 ` [PATCH 1/2] git.txt: fix synopsis of `--config-env` missing the equals sign Patrick Steinhardt 2021-04-19 15:56 ` [PATCH 2/2] git: support separate arg for `--config-env`'s value Patrick Steinhardt 2021-04-20 10:52 ` Ævar Arnfjörð Bjarmason 2021-04-23 10:07 ` Jeff King 2021-04-20 11:24 ` Ævar Arnfjörð Bjarmason 2021-04-29 12:55 ` Patrick Steinhardt [this message] 2021-04-29 12:55 ` [PATCH v2 1/2] git.txt: fix synopsis of `--config-env` missing the equals sign Patrick Steinhardt 2021-04-29 12:55 ` [PATCH v2 2/2] git: support separate arg for `--config-env`'s value Patrick Steinhardt 2021-04-29 20:04 ` [PATCH v2 0/2] " Jeff King 2021-04-30 0:47 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1619700731.git.ps@pks.im \ --to=ps@pks.im \ --cc=avarab@gmail.com \ --cc=git@vger.kernel.org \ --cc=peff@peff.net \ --subject='Re: [PATCH v2 0/2] git: support separate arg for `--config-env`'\''s value' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).