From: Jonathan Tan <jonathantanmy@google.com>
To: git@vger.kernel.org
Cc: Jonathan Tan <jonathantanmy@google.com>,
gitster@pobox.com, stolee@gmail.com
Subject: [PATCH v2 0/2] Fix overriding of partial clone filter when lazy-fetching
Date: Mon, 28 Sep 2020 15:26:36 -0700 [thread overview]
Message-ID: <cover.1601331788.git.jonathantanmy@google.com> (raw)
In-Reply-To: <cover.1600743698.git.jonathantanmy@google.com>
Thanks everyone for your comments. Patch 1 is exactly the same, and in
patch 2, I've changed the config check to use test_cmp_config with
"--get-all", as requested.
Comment noted about saying "this" without informing the reader what
it's referring to - in this case, it was about the issue in patch 2.
Jonathan Tan (2):
promisor-remote: remove unused variable
fetch: do not override partial clone filter
builtin/fetch.c | 2 +-
list-objects-filter-options.c | 10 +++++++++-
promisor-remote.c | 5 -----
promisor-remote.h | 2 +-
t/t5601-clone.sh | 3 ++-
5 files changed, 13 insertions(+), 9 deletions(-)
Range-diff against v1:
-: ---------- > 1: 625e7f148e promisor-remote: remove unused variable
1: af960f33b6 ! 2: c3ced59875 fetch: do not override partial clone filter
@@ list-objects-filter-options.c: void partial_clone_register(
## t/t5601-clone.sh ##
-@@ t/t5601-clone.sh: test_expect_success 'partial clone with -o' '
- git clone -o blah --filter=blob:limit=0 "file://$(pwd)/server" client
+@@ t/t5601-clone.sh: test_expect_success 'partial clone' '
+
+ test_expect_success 'partial clone with -o' '
+ partial_clone_server server &&
+- git clone -o blah --filter=blob:limit=0 "file://$(pwd)/server" client
++ git clone -o blah --filter=blob:limit=0 "file://$(pwd)/server" client &&
++ test_cmp_config -C client "blob:limit=0" --get-all remote.blah.partialclonefilter
'
-+test_expect_success 'ensure that filter is written to config' '
-+ FILTER=$(git -C client config --get remote.blah.partialclonefilter) &&
-+ test "$FILTER" = "blob:limit=0"
-+'
-+
test_expect_success 'partial clone: warn if server does not support object filtering' '
- rm -rf server client &&
- test_create_repo server &&
--
2.28.0.709.gb0816b6eb0-goog
next prev parent reply other threads:[~2020-09-28 23:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 3:03 [PATCH 0/2] Fix overriding of partial clone filter when lazy-fetching Jonathan Tan
2020-09-22 3:03 ` [PATCH 1/2] promisor-remote: remove unused variable Jonathan Tan
2020-09-22 3:03 ` [PATCH 2/2] fetch: do not override partial clone filter Jonathan Tan
2020-09-22 5:46 ` Junio C Hamano
2020-09-22 11:35 ` Derrick Stolee
2020-09-22 15:51 ` Junio C Hamano
2020-09-22 5:45 ` [PATCH 0/2] Fix overriding of partial clone filter when lazy-fetching Junio C Hamano
2020-09-28 22:26 ` Jonathan Tan [this message]
2020-09-28 22:26 ` [PATCH v2 1/2] promisor-remote: remove unused variable Jonathan Tan
2020-09-28 22:26 ` [PATCH v2 2/2] fetch: do not override partial clone filter Jonathan Tan
2020-09-28 23:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1601331788.git.jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).