From: Taylor Blau <me@ttaylorr.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com, jonathantanmy@google.com, jrnieder@gmail.com
Subject: [PATCH 0/5] shallow: extract a header file
Date: Wed, 29 Apr 2020 16:39:25 -0600 [thread overview]
Message-ID: <cover.1588199705.git.me@ttaylorr.com> (raw)
Hi,
These few patches are based on a suggestion in [1] from Jonathan Nieder
and in [2] Junio. The gist of this series is to do the following three
things:
1. Extract a new 'shallow.h' header to collect all of the functions
that are related to shallow-ness, but defined in 'commit.h'.
2. Add some documentation from the previous series where it could have
benefited from it.
3. Finally, introduce a thin wrapper type 'struct shallow_lock' which
makes it a type-level error to unlock a non-shallow lock with
'{commit,rollback}_shallow_file'.
The remainder of suggestions in [1] about the structure of t5537 I
decided to not address in this series, since I anticipate there is more
work there than I want to take on in this series alone.
Thanks in advance for your review!
[1]: https://lore.kernel.org/git/20200423011444.GG140314@google.com/
[2]: https://lore.kernel.org/git/xmqqy2qnidyy.fsf@gitster.c.googlers.com/
Taylor Blau (5):
commit: make 'commit_graft_pos' non-static
shallow: extract a header file for shallow-related functions
commit: move 'unregister_shallow' to 'shallow.h'
shallow.h: document '{commit,rollback}_shallow_file'
shallow: use struct 'shallow_lock' for additional safety
builtin.h | 1 +
builtin/receive-pack.c | 2 +-
commit.c | 16 ++-------
commit.h | 49 +-------------------------
fetch-pack.c | 3 +-
send-pack.c | 1 +
shallow.c | 36 +++++++++++++------
shallow.h | 78 ++++++++++++++++++++++++++++++++++++++++++
upload-pack.c | 1 +
9 files changed, 112 insertions(+), 75 deletions(-)
create mode 100644 shallow.h
--
2.26.0.113.ge9739cdccc
next reply other threads:[~2020-04-29 22:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 22:39 Taylor Blau [this message]
2020-04-29 22:39 ` [PATCH 1/5] commit: make 'commit_graft_pos' non-static Taylor Blau
2020-04-30 3:26 ` Jonathan Nieder
2020-04-30 19:22 ` Taylor Blau
2020-04-29 22:39 ` [PATCH 2/5] shallow: extract a header file for shallow-related functions Taylor Blau
2020-04-29 22:48 ` Eric Sunshine
2020-04-30 0:21 ` Jonathan Tan
2020-04-30 0:59 ` Taylor Blau
2020-04-30 18:23 ` Jonathan Tan
2020-04-30 3:19 ` Jonathan Nieder
2020-04-29 22:39 ` [PATCH 3/5] commit: move 'unregister_shallow' to 'shallow.h' Taylor Blau
2020-04-30 3:13 ` Jonathan Nieder
2020-04-30 19:29 ` Taylor Blau
2020-04-29 22:39 ` [PATCH 4/5] shallow.h: document '{commit,rollback}_shallow_file' Taylor Blau
2020-04-29 22:53 ` Eric Sunshine
2020-04-29 22:39 ` [PATCH 5/5] shallow: use struct 'shallow_lock' for additional safety Taylor Blau
2020-04-29 23:03 ` Eric Sunshine
2020-04-29 23:51 ` Taylor Blau
2020-04-30 0:30 ` Jonathan Tan
2020-04-30 3:11 ` Jonathan Nieder
2020-04-30 5:32 ` Eric Sunshine
2020-04-30 19:32 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1588199705.git.me@ttaylorr.com \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).