From: Jonathan Tan <jonathantanmy@google.com>
To: git@vger.kernel.org
Cc: Jonathan Tan <jonathantanmy@google.com>,
gitster@pobox.com, jrnieder@gmail.com
Subject: [PATCH v3 0/2] Un-regress rev-list --exclude-promisor-objects
Date: Sat, 11 Jan 2020 14:34:54 -0800 [thread overview]
Message-ID: <cover.1578781770.git.jonathantanmy@google.com> (raw)
In-Reply-To: <20191228003430.241283-1-jonathantanmy@google.com>
I took another look at this and tried to simplify things. The main
points were:
- there is a real bug
- it can be fixed by relying on get_reference() more
- but there was some discussion about what get_reference() does, so
I added some documentation first
Hopefully those main points were adequately conveyed in the new commit
messages, and I didn't oversimplify things.
There was some discussion about whether get_reference() should treat
corrupt objects as missing. After some thought, I think the best
argument for doing so is that this has been its behavior for some time,
and have wrote that in the first commit.
Jonathan Tan (2):
revision: document get_reference()
revision: un-regress --exclude-promisor-objects
revision.c | 12 +++++++++++-
t/t0410-partial-clone.sh | 12 +++---------
2 files changed, 14 insertions(+), 10 deletions(-)
--
2.25.0.rc1.283.g88dfdc4193-goog
next prev parent reply other threads:[~2020-01-11 22:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-28 0:34 [PATCH] revision: allow missing promisor objects on CLI Jonathan Tan
2019-12-28 3:50 ` Junio C Hamano
2019-12-30 18:38 ` Jonathan Tan
2019-12-30 20:33 ` Junio C Hamano
2019-12-30 23:44 ` [PATCH v2] " Jonathan Tan
2019-12-31 0:09 ` Jonathan Nieder
2020-01-02 20:49 ` Jonathan Tan
2020-01-11 22:34 ` Jonathan Tan [this message]
2020-01-11 22:34 ` [PATCH v3 1/2] revision: document get_reference() Jonathan Tan
2020-03-25 20:46 ` Emily Shaffer
2020-01-11 22:34 ` [PATCH v3 2/2] revision: un-regress --exclude-promisor-objects Jonathan Tan
2020-03-25 20:50 ` Emily Shaffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1578781770.git.jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).