From: Taylor Blau <me@ttaylorr.com>
To: stolee@gmail.com
Cc: git@vger.kernel.org, peff@peff.net
Subject: [RFC PATCH 0/1] commit-graph.c: handle corrupt commit trees
Date: Tue, 3 Sep 2019 22:22:38 -0400 [thread overview]
Message-ID: <cover.1567563244.git.me@ttaylorr.com> (raw)
Hi,
I was running some of the new 'git commit-graph' commands, and noticed
that I could consistently get 'git commit-graph write --reachable' to
segfault when a commit's root tree is corrupt.
I have an extremely-unfinished fix attached as an RFC PATCH below, but I
wanted to get a few thoughts on this before sending it out as a non-RFC.
In my patch, I simply 'die()' when a commit isn't able to be parsed
(i.e., when 'parse_commit_no_graph' returns a non-zero code), but I
wanted to see if others thought that this was an OK approach. Some
thoughts:
* It seems like we could write a commit-graph by placing a "filler"
entry where the broken commit would have gone. I don't see any place
where this is implemented currently, but this seems like a viable
alternative to not writing _any_ commits into the commit-graph.
* Could we learn about the corruption earlier? Ideally (in the obscene
of these placeholder objects that indicate corruption), we wouldn't
start writing a commit-graph until all of the objects in it are
known to be good.
This seems like a costly operation when it comes to memory, but
maybe I'm thinking about it the wrong way.
Depending on the approach here, I'll clean up the commit and message, as
well as add a test that demonstrates the breakage and subsequent fix.
Thanks in advance for your feedback :-).
Taylor Blau (1):
commit-graph.c: die on un-parseable commits
commit-graph.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--
2.22.0
next reply other threads:[~2019-09-04 2:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 2:22 Taylor Blau [this message]
2019-09-04 2:22 ` [RFC PATCH 1/1] commit-graph.c: die on un-parseable commits Taylor Blau
2019-09-04 3:04 ` Jeff King
2019-09-04 21:18 ` Taylor Blau
2019-09-05 6:47 ` Jeff King
2019-09-06 16:48 ` Derrick Stolee
2019-09-06 17:04 ` Jeff King
2019-09-06 17:19 ` Derrick Stolee
2019-09-06 17:20 ` Derrick Stolee
2019-09-05 22:19 ` Junio C Hamano
2019-09-06 6:35 ` Jeff King
2019-09-06 6:56 ` Jeff King
2019-09-06 16:59 ` Junio C Hamano
2019-09-06 17:04 ` Jeff King
2019-09-09 16:39 ` Junio C Hamano
2019-09-09 16:54 ` Jeff King
2019-09-04 18:25 ` [RFC PATCH 0/1] commit-graph.c: handle corrupt commit trees Garima Singh
2019-09-04 21:21 ` Taylor Blau
2019-09-05 6:08 ` Jeff King
2019-09-06 16:48 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1567563244.git.me@ttaylorr.com \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).