From: Denton Liu <liu.denton@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>, Beat Bolli <dev+git@drbeat.li>
Subject: [PATCH v3 0/2] format-patch: teach format.notes config option
Date: Fri, 10 May 2019 14:37:00 -0400 [thread overview]
Message-ID: <cover.1557513353.git.liu.denton@gmail.com> (raw)
In-Reply-To: <cover.1557327652.git.liu.denton@gmail.com>
Hi Beat, thanks for catching the style errors. This version fixes those.
Changes since v2:
* Fixed if-else code style
* Fixed typoed errors in 2/2 log message
Changes since v1:
* Made format.notes accept a notes ref instead of a boolean
Denton Liu (2):
git-format-patch.txt: document --no-notes option
format-patch: teach format.notes config option
Documentation/config/format.txt | 13 ++++++
Documentation/git-format-patch.txt | 7 ++-
builtin/log.c | 18 +++++++-
t/t4014-format-patch.sh | 70 ++++++++++++++++++++++++++++++
4 files changed, 106 insertions(+), 2 deletions(-)
Range-diff against v2:
1: 4c3535f25b = 1: 4c3535f25b git-format-patch.txt: document --no-notes option
2: fe674bf63e ! 2: df864c4adf format-patch: teach format.notes config option
@@ -8,8 +8,8 @@
that they may forget to include it and generate a patch series without
notes.
- Teach git-format-patch the `format.notes` config option its value is a
- notes ref that will be automatically be appended. The special value of
+ Teach git-format-patch the `format.notes` config option. Its value is a
+ notes ref that will be automatically appended. The special value of
"standard" can be used to specify the standard notes. This option is
overridable with the `--no-notes` option in case a user wishes not to
append notes.
@@ -71,9 +71,9 @@
+ struct strbuf buf = STRBUF_INIT;
+
+ rev->show_notes = 1;
-+ if (!strcmp(value, "standard"))
++ if (!strcmp(value, "standard")) {
+ rev->notes_opt.use_default_notes = 1;
-+ else {
++ } else {
+ strbuf_addstr(&buf, value);
+ expand_notes_ref(&buf);
+ string_list_append(&rev->notes_opt.extra_notes_refs,
--
2.21.0.1049.geb646f7864
next prev parent reply other threads:[~2019-05-10 18:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-27 19:25 [PATCH 0/2] format-patch: teach format.notes config option Denton Liu
2019-04-27 19:25 ` [PATCH 1/2] git-format-patch.txt: document --no-notes option Denton Liu
2019-04-27 19:25 ` [PATCH 2/2] format-patch: teach format.notes config option Denton Liu
2019-05-07 4:43 ` Junio C Hamano
2019-05-08 15:02 ` [PATCH v2 0/2] " Denton Liu
2019-05-08 15:02 ` [PATCH v2 1/2] git-format-patch.txt: document --no-notes option Denton Liu
2019-05-08 15:02 ` [PATCH v2 2/2] format-patch: teach format.notes config option Denton Liu
2019-05-08 17:18 ` Beat Bolli
2019-05-08 17:31 ` Denton Liu
2019-05-08 17:52 ` Beat Bolli
2019-05-10 18:37 ` Denton Liu [this message]
2019-05-10 18:37 ` [PATCH v3 1/2] git-format-patch.txt: document --no-notes option Denton Liu
2019-05-10 18:37 ` [PATCH v3 2/2] format-patch: teach format.notes config option Denton Liu
2019-05-13 2:44 ` Junio C Hamano
2019-05-14 17:01 ` Denton Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1557513353.git.liu.denton@gmail.com \
--to=liu.denton@gmail.com \
--cc=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).