From: Denton Liu <liu.denton@gmail.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com
Subject: [PATCH v4 0/3] Teach submodule set-branch subcommand
Date: Fri, 8 Feb 2019 03:21:25 -0800 [thread overview]
Message-ID: <cover.1549624679.git.liu.denton@gmail.com> (raw)
In-Reply-To: <cover.1549534460.git.liu.denton@gmail.com>
Thanks so much for the feedback, Junio. I've updated the patchset based
on your comments.
Currently, there is no way to set the branch of a submodule without
manually manipulating the .gitmodules file. This patchset introduces a
porcelain command that enables this.
Changes since v1:
* Fixed incorrect usage of OPT_CMDMODE
Changes since v2:
* Corrected missing argument for -b/--branch in git-submodule.txt
* Rebased onto latest next
Changes since v3:
* Rebased back onto master
* Address Junio's comments and improve clarity of submodule--helper patch
* Fix incorrect documentation formatting in git-submodule.txt
Denton Liu (3):
git-submodule.txt: "--branch <branch>" option defaults to 'master'
submodule--helper: teach config subcommand --unset
submodule: teach set-branch subcommand
Documentation/git-submodule.txt | 14 +++-
builtin/submodule--helper.c | 17 +++--
contrib/completion/git-completion.bash | 5 +-
git-submodule.sh | 75 +++++++++++++++++++--
t/t7411-submodule-config.sh | 9 +++
t/t7419-submodule-set-branch.sh | 93 ++++++++++++++++++++++++++
6 files changed, 200 insertions(+), 13 deletions(-)
create mode 100755 t/t7419-submodule-set-branch.sh
--
2.20.1.522.g5f42c252e9
next prev parent reply other threads:[~2019-02-08 11:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 10:59 [PATCH 0/3] Teach submodule set-branch subcommand Denton Liu
2019-02-06 10:59 ` [PATCH 1/3] git-submodule.txt: document default behavior without --branch Denton Liu
2019-02-06 18:46 ` Junio C Hamano
2019-02-06 10:59 ` [PATCH 2/3] submodule--helper: teach config subcommand --unset Denton Liu
2019-02-06 19:07 ` Junio C Hamano
2019-02-06 10:59 ` [PATCH 3/3] submodule: teach set-branch subcommand Denton Liu
2019-02-07 6:32 ` [PATCH v2 0/3] Teach submodule " Denton Liu
2019-02-07 6:32 ` [PATCH v2 1/3] git-submodule.txt: document default behavior without --branch Denton Liu
2019-02-07 6:32 ` [PATCH v2 2/3] submodule--helper: teach config subcommand --unset Denton Liu
2019-02-07 6:33 ` [PATCH v2 3/3] submodule: teach set-branch subcommand Denton Liu
2019-02-07 10:18 ` [PATCH v3 0/3] Teach submodule " Denton Liu
2019-02-07 10:18 ` [PATCH v3 1/3] git-submodule.txt: "--branch <branch>" option defaults to 'master' Denton Liu
2019-02-07 10:18 ` [PATCH v3 2/3] submodule--helper: teach config subcommand --unset Denton Liu
2019-02-07 20:05 ` Junio C Hamano
2019-02-07 22:29 ` Junio C Hamano
2019-02-07 10:19 ` [PATCH v3 3/3] submodule: teach set-branch subcommand Denton Liu
2019-02-07 22:26 ` Junio C Hamano
2019-02-07 18:01 ` [PATCH v3 0/3] Teach submodule " Junio C Hamano
2019-02-08 5:31 ` Denton Liu
2019-02-08 18:43 ` Junio C Hamano
2019-02-08 11:21 ` Denton Liu [this message]
2019-02-08 11:21 ` [PATCH v4 1/3] git-submodule.txt: "--branch <branch>" option defaults to 'master' Denton Liu
2019-02-08 11:21 ` [PATCH v4 2/3] submodule--helper: teach config subcommand --unset Denton Liu
2019-02-08 11:21 ` [PATCH v4 3/3] submodule: teach set-branch subcommand Denton Liu
2019-02-08 23:51 ` Denton Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1549624679.git.liu.denton@gmail.com \
--to=liu.denton@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).