From: Josh Steadmon <steadmon@google.com>
To: git@vger.kernel.org
Subject: [PATCH v6 0/1] Advertise multiple supported proto versions
Date: Thu, 20 Dec 2018 13:58:07 -0800 [thread overview]
Message-ID: <cover.1545342797.git.steadmon@google.com> (raw)
In-Reply-To: <cover.1538516853.git.steadmon@google.com>
Add a registry of supported wire protocol versions that individual
commands can use to declare supported versions before contacting a
server. The client will then advertise all supported versions, while the
server will choose the first allowed version from the advertised
list.
Every command that acts as a client or server must now register its
supported protocol versions.
Changes since V4: remove special cases around advertising version=0.
Changes since V5: no code changes, but corrected and clarified commit
message regarding changes around advertising version=0.
Josh Steadmon (1):
protocol: advertise multiple supported versions
builtin/archive.c | 3 +
builtin/clone.c | 4 ++
builtin/fetch-pack.c | 4 ++
builtin/fetch.c | 5 ++
builtin/ls-remote.c | 5 ++
builtin/pull.c | 5 ++
builtin/push.c | 4 ++
builtin/receive-pack.c | 3 +
builtin/send-pack.c | 3 +
builtin/upload-archive.c | 3 +
builtin/upload-pack.c | 4 ++
connect.c | 52 +++++++--------
protocol.c | 122 +++++++++++++++++++++++++++++++++---
protocol.h | 23 ++++++-
remote-curl.c | 27 +++++---
t/t5551-http-fetch-smart.sh | 1 +
t/t5570-git-daemon.sh | 2 +-
t/t5601-clone.sh | 38 +++++------
t/t5700-protocol-v1.sh | 8 +--
t/t5702-protocol-v2.sh | 16 +++--
transport-helper.c | 6 ++
21 files changed, 256 insertions(+), 82 deletions(-)
Range-diff against v5:
1: 60f6f2fbd8 ! 1: 10039ca163 protocol: advertise multiple supported versions
@@ -22,10 +22,12 @@
select the first allowed version from this advertisement.
Additionally, remove special cases around advertising version=0.
- Previously we avoided adding version negotiation fields in server
- responses if it looked like the client wanted v0. However, including
- these fields does not change behavior, so it's better to have simpler
- code.
+ Previously we avoided adding version advertisements to the client's
+ initial connection request if the client wanted version=0. However,
+ including these advertisements does not change the version negotiation
+ behavior, so it's better to have simpler code. As a side effect, this
+ means that client operations over SSH will always include a
+ "SendEnv=GIT_PROTOCOL" option on the SSH command line.
While we're at it, remove unnecessary externs from function declarations
in protocol.h.
--
2.20.1.415.g653613c723-goog
next prev parent reply other threads:[~2018-12-20 21:58 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 21:59 [PATCH 0/1] Limit client version advertisements Josh Steadmon
2018-10-02 21:59 ` [PATCH 1/1] protocol: limit max protocol version per service Josh Steadmon
2018-10-02 22:28 ` Stefan Beller
2018-10-03 21:33 ` Josh Steadmon
2018-10-03 22:47 ` Stefan Beller
2018-10-05 0:18 ` Josh Steadmon
2018-10-05 19:25 ` Stefan Beller
2018-10-10 23:53 ` Josh Steadmon
2018-10-12 23:30 ` Jonathan Nieder
2018-10-12 23:32 ` Jonathan Nieder
2018-10-12 23:45 ` Josh Steadmon
2018-10-12 23:53 ` Jonathan Nieder
2018-10-13 7:58 ` Junio C Hamano
2018-10-12 1:02 ` [PATCH v2 0/1] Advertise multiple supported proto versions steadmon
2018-10-12 1:02 ` [PATCH v2 1/1] protocol: advertise multiple supported versions steadmon
2018-10-12 22:30 ` Stefan Beller
2018-10-22 22:55 ` Josh Steadmon
2018-10-23 0:37 ` Stefan Beller
2018-11-12 21:49 ` [PATCH v3 0/1] Advertise multiple supported proto versions steadmon
2018-11-12 21:49 ` [PATCH v3 1/1] protocol: advertise multiple supported versions steadmon
2018-11-12 22:33 ` Stefan Beller
2018-11-13 3:24 ` Re* " Junio C Hamano
2018-11-13 19:21 ` Stefan Beller
2018-11-14 2:31 ` Junio C Hamano
2018-11-13 4:01 ` Junio C Hamano
2018-11-13 22:53 ` Josh Steadmon
2018-11-14 2:38 ` Junio C Hamano
2018-11-14 19:57 ` Josh Steadmon
2018-11-16 2:45 ` Junio C Hamano
2018-11-16 19:59 ` Josh Steadmon
2018-11-13 13:35 ` Junio C Hamano
2018-11-13 18:28 ` SZEDER Gábor
2018-11-13 23:03 ` Josh Steadmon
2018-11-14 0:47 ` SZEDER Gábor
2018-11-14 2:44 ` Junio C Hamano
2018-11-14 11:01 ` SZEDER Gábor
2018-11-14 2:30 ` [PATCH v4 0/1] Advertise multiple supported proto versions Josh Steadmon
2018-11-14 2:30 ` [PATCH v4 1/1] protocol: advertise multiple supported versions Josh Steadmon
2018-11-14 10:22 ` [PATCH v4 0/1] Advertise multiple supported proto versions Junio C Hamano
2018-11-14 19:51 ` Josh Steadmon
2018-11-16 10:46 ` Junio C Hamano
2018-11-16 22:34 ` [PATCH v5 " Josh Steadmon
2018-11-16 22:34 ` [PATCH v5 1/1] protocol: advertise multiple supported versions Josh Steadmon
2018-12-14 20:20 ` Ævar Arnfjörð Bjarmason
2018-12-14 21:58 ` Josh Steadmon
2018-12-14 22:39 ` Ævar Arnfjörð Bjarmason
2018-12-18 23:05 ` Josh Steadmon
2018-12-20 21:58 ` Josh Steadmon [this message]
2018-12-20 21:58 ` [PATCH v6 " Josh Steadmon
2019-02-05 19:42 ` Jonathan Tan
2019-02-07 23:58 ` Josh Steadmon
2019-02-11 18:53 ` Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1545342797.git.steadmon@google.com \
--to=steadmon@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).