From: Jonathan Tan <jonathantanmy@google.com>
To: git@vger.kernel.org
Cc: Jonathan Tan <jonathantanmy@google.com>, sunshine@sunshineco.com
Subject: [PATCH v2 0/2] Cookie redaction during GIT_TRACE_CURL
Date: Thu, 18 Jan 2018 16:28:00 -0800 [thread overview]
Message-ID: <cover.1516321355.git.jonathantanmy@google.com> (raw)
In-Reply-To: <cover.1516235197.git.jonathantanmy@google.com>
Thanks, Eric. Changes in v2:
- documented all environment variables introduced
- made test more clear by ensuring that no cookie keys are suffixes or
prefixes of others
- tested empty value
As far as I can tell, it does not seem possible that Git generates a
cookie with no equals sign (like "Secure" or "HttpOnly" described in RFC
6265). When I try to craft a cookie file containing that (using
"Set-Cookie: Foo=; HttpOnly", for example), the no-equals-sign cookie
just disappears.
Jonathan Tan (2):
http: support cookie redaction when tracing
http: support omitting data from traces
Documentation/git.txt | 10 ++++++
http.c | 82 ++++++++++++++++++++++++++++++++++++++++-----
t/t5551-http-fetch-smart.sh | 33 ++++++++++++++++++
3 files changed, 117 insertions(+), 8 deletions(-)
--
2.16.0.rc2.37.ge0d575025.dirty
next prev parent reply other threads:[~2018-01-19 0:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 0:34 [RFC PATCH 0/2] Cookie redaction during GIT_TRACE_CURL Jonathan Tan
2018-01-18 0:34 ` [RFC PATCH 1/2] http: support cookie redaction when tracing Jonathan Tan
2018-01-18 18:25 ` Eric Sunshine
2018-01-18 0:34 ` [RFC PATCH 2/2] http: support omitting data from traces Jonathan Tan
2018-01-18 18:25 ` Eric Sunshine
2018-01-19 0:28 ` Jonathan Tan [this message]
2018-01-19 0:28 ` [PATCH v2 1/2] http: support cookie redaction when tracing Jonathan Tan
2018-01-19 0:28 ` [PATCH v2 2/2] http: support omitting data from traces Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1516321355.git.jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).