git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Stefan Beller" <sbeller@google.com>,
	"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	"Jeff King" <peff@peff.net>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Brandon Williams" <bmwill@google.com>,
	git@vger.kernel.org, "Michael Haggerty" <mhagger@alum.mit.edu>
Subject: [PATCH v3 00/21] Read `packed-refs` using mmap()
Date: Mon, 25 Sep 2017 09:59:57 +0200	[thread overview]
Message-ID: <cover.1506325610.git.mhagger@alum.mit.edu> (raw)

This is v3 of a patch series that changes the reading and caching of
the `packed-refs` file to use `mmap()`. Thanks to Stefan, Peff, Dscho,
and Junio for their comments about v2. I think I have addressed all of
the feedback from v1 [1] and v2 [2].

This version has only minor changes relative to v2:

* Fixed a trivial error in the commit message for patch 08.

* In patch 13:

  * In the commit message, explain the appearance of `MMAP_TEMPORARY`
    even though it is not yet treated differently than `MMAP_NONE`.

  * In `Makefile`, don't make `USE_WIN32_MMAP` imply
    `MMAP_PREVENTS_DELETE`.

  * Correct the type of a local variable from `size_t` to `ssize_t`.

This patch series is also available from my GitHub repo [3] as branch
`mmap-packed-refs`.

[1] http://public-inbox.org/git/cover.1505319366.git.mhagger@alum.mit.edu/
[2] https://public-inbox.org/git/cover.1505799700.git.mhagger@alum.mit.edu/
[3] https://github.com/mhagger/git/

Jeff King (1):
  prefix_ref_iterator: break when we leave the prefix

Michael Haggerty (20):
  ref_iterator: keep track of whether the iterator output is ordered
  packed_ref_cache: add a backlink to the associated `packed_ref_store`
  die_unterminated_line(), die_invalid_line(): new functions
  read_packed_refs(): use mmap to read the `packed-refs` file
  read_packed_refs(): only check for a header at the top of the file
  read_packed_refs(): make parsing of the header line more robust
  read_packed_refs(): read references with minimal copying
  packed_ref_cache: remember the file-wide peeling state
  mmapped_ref_iterator: add iterator over a packed-refs file
  mmapped_ref_iterator_advance(): no peeled value for broken refs
  packed-backend.c: reorder some definitions
  packed_ref_cache: keep the `packed-refs` file mmapped if possible
  read_packed_refs(): ensure that references are ordered when read
  packed_ref_iterator_begin(): iterate using `mmapped_ref_iterator`
  packed_read_raw_ref(): read the reference from the mmapped buffer
  ref_store: implement `refs_peel_ref()` generically
  packed_ref_store: get rid of the `ref_cache` entirely
  ref_cache: remove support for storing peeled values
  mmapped_ref_iterator: inline into `packed_ref_iterator`
  packed-backend.c: rename a bunch of things and update comments

 Makefile              |   6 +
 config.mak.uname      |   3 +
 refs.c                |  22 +-
 refs/files-backend.c  |  54 +--
 refs/iterator.c       |  47 ++-
 refs/packed-backend.c | 979 ++++++++++++++++++++++++++++++++++++++------------
 refs/ref-cache.c      |  44 +--
 refs/ref-cache.h      |  35 +-
 refs/refs-internal.h  |  26 +-
 9 files changed, 847 insertions(+), 369 deletions(-)

-- 
2.14.1


             reply	other threads:[~2017-09-25  8:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25  7:59 Michael Haggerty [this message]
2017-09-25  7:59 ` [PATCH v3 01/21] ref_iterator: keep track of whether the iterator output is ordered Michael Haggerty
2017-09-25  7:59 ` [PATCH v3 02/21] prefix_ref_iterator: break when we leave the prefix Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 03/21] packed_ref_cache: add a backlink to the associated `packed_ref_store` Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 04/21] die_unterminated_line(), die_invalid_line(): new functions Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 05/21] read_packed_refs(): use mmap to read the `packed-refs` file Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 06/21] read_packed_refs(): only check for a header at the top of the file Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 07/21] read_packed_refs(): make parsing of the header line more robust Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 08/21] read_packed_refs(): read references with minimal copying Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 09/21] packed_ref_cache: remember the file-wide peeling state Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 10/21] mmapped_ref_iterator: add iterator over a packed-refs file Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 11/21] mmapped_ref_iterator_advance(): no peeled value for broken refs Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 12/21] packed-backend.c: reorder some definitions Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 13/21] packed_ref_cache: keep the `packed-refs` file mmapped if possible Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 14/21] read_packed_refs(): ensure that references are ordered when read Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 15/21] packed_ref_iterator_begin(): iterate using `mmapped_ref_iterator` Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 16/21] packed_read_raw_ref(): read the reference from the mmapped buffer Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 17/21] ref_store: implement `refs_peel_ref()` generically Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 18/21] packed_ref_store: get rid of the `ref_cache` entirely Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 19/21] ref_cache: remove support for storing peeled values Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 20/21] mmapped_ref_iterator: inline into `packed_ref_iterator` Michael Haggerty
2017-09-25  8:00 ` [PATCH v3 21/21] packed-backend.c: rename a bunch of things and update comments Michael Haggerty
2017-09-25 12:22 ` [PATCH v3 00/21] Read `packed-refs` using mmap() Jeff King
2017-09-29  2:13   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1506325610.git.mhagger@alum.mit.edu \
    --to=mhagger@alum.mit.edu \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=avarab@gmail.com \
    --cc=bmwill@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    --cc=sbeller@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).