From: Thomas Rast <tr@thomasrast.ch>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Subject: [PATCH 0/2] Revert --valgrind-parallel test option
Date: Sat, 19 Oct 2013 23:06:06 +0200 [thread overview]
Message-ID: <cover.1382215973.git.tr@thomasrast.ch> (raw)
These patches remove the --valgrind-parallel=N option that was broken
from the outset (shame on me). Peff's judgement at the time that its
usefulness would approximately be "meh" turns out to be correct.
What's not in the commit message, but drives part of my reasoning in
doing a revert instead of a fix: I did fix it up locally only to
notice that it was too slow in this case for what I actually wanted to
use it for. The only valgrind-test workflow that I find bearable is
to run all the tests in the background under prove (takes hours), and
then use the prove output (which says exactly which subtests fail) in
--valgrind-only=<subtest>. So the latter is -- again Peff was right
-- the really useful thing.
The only consolation is that I apparently didn't break any other use
of the test suite -- otherwise it would presumably have been fixed
very quickly.
Thomas Rast (2):
Revert "test-lib: support running tests under valgrind in parallel"
Revert "test-lib: allow prefixing a custom string before "ok N" etc."
t/test-lib.sh | 133 +++++++++++++++-------------------------------------------
1 file changed, 34 insertions(+), 99 deletions(-)
--
1.8.4.1.810.g312044e
next reply other threads:[~2013-10-19 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-19 21:06 Thomas Rast [this message]
2013-10-19 21:06 ` [PATCH 1/2] Revert "test-lib: support running tests under valgrind in parallel" Thomas Rast
2013-10-19 21:06 ` [PATCH 2/2] Revert "test-lib: allow prefixing a custom string before "ok N" etc." Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1382215973.git.tr@thomasrast.ch \
--to=tr@thomasrast.ch \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).