* [PATCH] gitweb: Ensure OPML text fits inside its box. @ 2013-07-09 16:43 Tony Finch 2013-07-09 17:08 ` [PATCH] gitweb: vertically centre contents of page footer Tony Finch 2013-07-14 23:49 ` [PATCH] gitweb: Ensure OPML text fits inside its box Jonathan Nieder 0 siblings, 2 replies; 20+ messages in thread From: Tony Finch @ 2013-07-09 16:43 UTC (permalink / raw) To: git; +Cc: Jakub Narębski The rss_logo CSS style has a fixed width which is too narrow for the string "OPML". Replace the fixed width with horizontal padding so the text fits with nice margins. --- For before/after examples, see http://dotat.at/cgi/git (overflow) and https://git.csx.cam.ac.uk/x/ucs/ (padded). gitweb/static/gitweb.css | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css index cb86d2d..a869be1 100644 --- a/gitweb/static/gitweb.css +++ b/gitweb/static/gitweb.css @@ -548,8 +548,7 @@ a.linenr { a.rss_logo { float: right; - padding: 3px 0px; - width: 35px; + padding: 3px 5px; line-height: 10px; border: 1px solid; border-color: #fcc7a5 #7d3302 #3e1a01 #ff954e; -- 1.8.3.1.605.g85318f5 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH] gitweb: vertically centre contents of page footer 2013-07-09 16:43 [PATCH] gitweb: Ensure OPML text fits inside its box Tony Finch @ 2013-07-09 17:08 ` Tony Finch 2013-07-14 23:49 ` [PATCH] gitweb: Ensure OPML text fits inside its box Jonathan Nieder 1 sibling, 0 replies; 20+ messages in thread From: Tony Finch @ 2013-07-09 17:08 UTC (permalink / raw) To: git; +Cc: Jakub Narębski --- gitweb/static/gitweb.css | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css index a869be1..3b4d833 100644 --- a/gitweb/static/gitweb.css +++ b/gitweb/static/gitweb.css @@ -68,12 +68,13 @@ div.page_path { } div.page_footer { - height: 17px; + height: 22px; padding: 4px 8px; background-color: #d9d8d1; } div.page_footer_text { + line-height: 22px; float: left; color: #555555; font-style: italic; -- 1.8.3.1.605.g85318f5 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH] gitweb: Ensure OPML text fits inside its box. 2013-07-09 16:43 [PATCH] gitweb: Ensure OPML text fits inside its box Tony Finch 2013-07-09 17:08 ` [PATCH] gitweb: vertically centre contents of page footer Tony Finch @ 2013-07-14 23:49 ` Jonathan Nieder 2013-07-02 16:24 ` [PATCH 3/4] gitweb: omit the repository owner when it is unset Tony Finch ` (6 more replies) 1 sibling, 7 replies; 20+ messages in thread From: Jonathan Nieder @ 2013-07-14 23:49 UTC (permalink / raw) To: Tony Finch; +Cc: git, Jakub Narębski Tony Finch wrote: > The rss_logo CSS style has a fixed width which is too narrow for > the string "OPML". Replace the fixed width with horizontal padding > so the text fits with nice margins. Sounds sensible. Can we have your sign-off? (Likewise for the next patch.) Thanks, Jonathan ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 3/4] gitweb: omit the repository owner when it is unset 2013-07-14 23:49 ` [PATCH] gitweb: Ensure OPML text fits inside its box Jonathan Nieder @ 2013-07-02 16:24 ` Tony Finch 2013-07-09 16:43 ` [PATCH 1/4] gitweb: Ensure OPML text fits inside its box Tony Finch ` (5 subsequent siblings) 6 siblings, 0 replies; 20+ messages in thread From: Tony Finch @ 2013-07-02 16:24 UTC (permalink / raw) To: git; +Cc: Jakub Narębski, Jonathan Nieder On the repository summary page, leave the whole owner line out if the repo does not have an owner, rather than displaying a labelled empty field.. Signed-off-by: Tony Finch <dot@dotat.at> --- gitweb/gitweb.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 8d69ada..c029b98 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -6463,7 +6463,7 @@ sub git_summary { print "<div class=\"title\"> </div>\n"; print "<table class=\"projects_list\">\n" . "<tr id=\"metadata_desc\"><td>description</td><td>" . esc_html($descr) . "</td></tr>\n"; - unless ($omit_owner) { + if ($owner and not $omit_owner) { print "<tr id=\"metadata_owner\"><td>owner</td><td>" . esc_html($owner) . "</td></tr>\n"; } if (defined $cd{'rfc2822'}) { -- 1.8.3.1.605.g85318f5 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 1/4] gitweb: Ensure OPML text fits inside its box. 2013-07-14 23:49 ` [PATCH] gitweb: Ensure OPML text fits inside its box Jonathan Nieder 2013-07-02 16:24 ` [PATCH 3/4] gitweb: omit the repository owner when it is unset Tony Finch @ 2013-07-09 16:43 ` Tony Finch 2013-07-09 17:08 ` [PATCH 2/4] gitweb: vertically centre contents of page footer Tony Finch ` (4 subsequent siblings) 6 siblings, 0 replies; 20+ messages in thread From: Tony Finch @ 2013-07-09 16:43 UTC (permalink / raw) To: git; +Cc: Jakub Narębski, Jonathan Nieder The rss_logo CSS style has a fixed width which is too narrow for the string "OPML". Replace the fixed width with horizontal padding so the text fits with nice margins. Signed-off-by: Tony Finch <dot@dotat.at> --- gitweb/static/gitweb.css | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css index cb86d2d..a869be1 100644 --- a/gitweb/static/gitweb.css +++ b/gitweb/static/gitweb.css @@ -548,8 +548,7 @@ a.linenr { a.rss_logo { float: right; - padding: 3px 0px; - width: 35px; + padding: 3px 5px; line-height: 10px; border: 1px solid; border-color: #fcc7a5 #7d3302 #3e1a01 #ff954e; -- 1.8.3.1.605.g85318f5 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 2/4] gitweb: vertically centre contents of page footer 2013-07-14 23:49 ` [PATCH] gitweb: Ensure OPML text fits inside its box Jonathan Nieder 2013-07-02 16:24 ` [PATCH 3/4] gitweb: omit the repository owner when it is unset Tony Finch 2013-07-09 16:43 ` [PATCH 1/4] gitweb: Ensure OPML text fits inside its box Tony Finch @ 2013-07-09 17:08 ` Tony Finch 2013-07-09 17:15 ` [PATCH 4/4] gitweb: make search help link less ugly Tony Finch ` (3 subsequent siblings) 6 siblings, 0 replies; 20+ messages in thread From: Tony Finch @ 2013-07-09 17:08 UTC (permalink / raw) To: git; +Cc: Jakub Narębski, Jonathan Nieder Signed-off-by: Tony Finch <dot@dotat.at> --- gitweb/static/gitweb.css | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css index a869be1..3b4d833 100644 --- a/gitweb/static/gitweb.css +++ b/gitweb/static/gitweb.css @@ -68,12 +68,13 @@ div.page_path { } div.page_footer { - height: 17px; + height: 22px; padding: 4px 8px; background-color: #d9d8d1; } div.page_footer_text { + line-height: 22px; float: left; color: #555555; font-style: italic; -- 1.8.3.1.605.g85318f5 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 4/4] gitweb: make search help link less ugly 2013-07-14 23:49 ` [PATCH] gitweb: Ensure OPML text fits inside its box Jonathan Nieder ` (2 preceding siblings ...) 2013-07-09 17:08 ` [PATCH 2/4] gitweb: vertically centre contents of page footer Tony Finch @ 2013-07-09 17:15 ` Tony Finch 2013-07-15 9:15 ` [PATCH] gitweb: Ensure OPML text fits inside its box Tony Finch ` (2 subsequent siblings) 6 siblings, 0 replies; 20+ messages in thread From: Tony Finch @ 2013-07-09 17:15 UTC (permalink / raw) To: git; +Cc: Jakub Narębski, Jonathan Nieder The search help link was a superscript question mark right next to a drop-down menu, which looks misaligned and is a cramped and awkward click target. Remove the superscript tags and add some spacing to fix these nits. Add a title attribute to provide an explanatory mouseover. Signed-off-by: Tony Finch <dot@dotat.at> --- gitweb/gitweb.perl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index c029b98..874c948 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -4029,9 +4029,9 @@ sub print_search_form { $cgi->input({-name=>"a", -value=>"search", -type=>"hidden"}) . "\n" . $cgi->input({-name=>"h", -value=>$search_hash, -type=>"hidden"}) . "\n" . $cgi->popup_menu(-name => 'st', -default => 'commit', - -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) . - $cgi->sup($cgi->a({-href => href(action=>"search_help")}, "?")) . - " search:\n", + -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) . + " " . $cgi->a({-href => href(action=>"search_help"), + -title => "search help" }, "?") . " search:\n", $cgi->textfield(-name => "s", -value => $searchtext, -override => 1) . "\n" . "<span title=\"Extended regular expression\">" . $cgi->checkbox(-name => 'sr', -value => 1, -label => 're', -- 1.8.3.1.605.g85318f5 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH] gitweb: Ensure OPML text fits inside its box. 2013-07-14 23:49 ` [PATCH] gitweb: Ensure OPML text fits inside its box Jonathan Nieder ` (3 preceding siblings ...) 2013-07-09 17:15 ` [PATCH 4/4] gitweb: make search help link less ugly Tony Finch @ 2013-07-15 9:15 ` Tony Finch [not found] ` <E1Uyeth-0003TF-Kx@hermes-2.csi.cam.ac.uk> [not found] ` <E1Uyete-0003Sv-OI@hermes-2.csi.cam.ac.uk> 6 siblings, 0 replies; 20+ messages in thread From: Tony Finch @ 2013-07-15 9:15 UTC (permalink / raw) To: Jonathan Nieder; +Cc: git, Jakub Narębski Jonathan Nieder <jrnieder@gmail.com> wrote: > > Sounds sensible. Can we have your sign-off? (Likewise for the next > patch.) Doh! Thanks for looking at the patches. I'll post revised versions, plus a couple more tweaks. Tony. -- f.anthony.n.finch <dot@dotat.at> http://dotat.at/ Forties, Cromarty: East, veering southeast, 4 or 5, occasionally 6 at first. Rough, becoming slight or moderate. Showers, rain at first. Moderate or good, occasionally poor at first. ^ permalink raw reply [flat|nested] 20+ messages in thread
[parent not found: <E1Uyeth-0003TF-Kx@hermes-2.csi.cam.ac.uk>]
* Re: [PATCH 4/4] gitweb: make search help link less ugly [not found] ` <E1Uyeth-0003TF-Kx@hermes-2.csi.cam.ac.uk> @ 2013-08-03 21:37 ` Jakub Narębski 2013-08-05 11:19 ` Tony Finch 0 siblings, 1 reply; 20+ messages in thread From: Jakub Narębski @ 2013-08-03 21:37 UTC (permalink / raw) To: Tony Finch; +Cc: git, Jonathan Nieder On Tue, Jul 9, 2013 at 7:15 PM, Tony Finch <dot@dotat.at> wrote: > The search help link was a superscript question mark right next to > a drop-down menu, which looks misaligned I think the idea was to simulate footnote explaining search terms (I think, I am not the author of this feature)... > and is a cramped and > awkward click target. Remove the superscript tags and add some > spacing to fix these nits. Add a title attribute to provide an > explanatory mouseover. ... but I agree that it makes for poor UI. > > Signed-off-by: Tony Finch <dot@dotat.at> > --- > gitweb/gitweb.perl | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl > index c029b98..874c948 100755 > --- a/gitweb/gitweb.perl > +++ b/gitweb/gitweb.perl > @@ -4029,9 +4029,9 @@ sub print_search_form { > $cgi->input({-name=>"a", -value=>"search", -type=>"hidden"}) . "\n" . > $cgi->input({-name=>"h", -value=>$search_hash, -type=>"hidden"}) . "\n" . > $cgi->popup_menu(-name => 'st', -default => 'commit', > - -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) . > - $cgi->sup($cgi->a({-href => href(action=>"search_help")}, "?")) . > - " search:\n", > + -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) . Nb. what changed here (in line above)? > + " " . $cgi->a({-href => href(action=>"search_help"), > + -title => "search help" }, "?") . " search:\n", > $cgi->textfield(-name => "s", -value => $searchtext, -override => 1) . "\n" . > "<span title=\"Extended regular expression\">" . > $cgi->checkbox(-name => 'sr', -value => 1, -label => 're', > -- > 1.8.3.1.605.g85318f5 ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 4/4] gitweb: make search help link less ugly 2013-08-03 21:37 ` [PATCH 4/4] gitweb: make search help link less ugly Jakub Narębski @ 2013-08-05 11:19 ` Tony Finch 0 siblings, 0 replies; 20+ messages in thread From: Tony Finch @ 2013-08-05 11:19 UTC (permalink / raw) To: Jakub Narębski; +Cc: git, Jonathan Nieder, Tony Finch [-- Attachment #1: Type: TEXT/PLAIN, Size: 609 bytes --] Jakub Narębski <jnareb@gmail.com> wrote: > > - -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) . > > + -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) . > > Nb. what changed here (in line above)? Whoops, tab damage. I will re-roll. Thanks for the review. Tony. -- f.anthony.n.finch <dot@dotat.at> http://dotat.at/ Forties, Cromarty: East, veering southeast, 4 or 5, occasionally 6 at first. Rough, becoming slight or moderate. Showers, rain at first. Moderate or good, occasionally poor at first. ^ permalink raw reply [flat|nested] 20+ messages in thread
[parent not found: <E1Uyete-0003Sv-OI@hermes-2.csi.cam.ac.uk>]
* Re: [PATCH 3/4] gitweb: omit the repository owner when it is unset [not found] ` <E1Uyete-0003Sv-OI@hermes-2.csi.cam.ac.uk> @ 2013-08-03 21:40 ` Jakub Narębski 2013-08-05 11:36 ` Tony Finch 0 siblings, 1 reply; 20+ messages in thread From: Jakub Narębski @ 2013-08-03 21:40 UTC (permalink / raw) To: Tony Finch; +Cc: git, Jonathan Nieder On Tue, Jul 2, 2013 at 6:24 PM, Tony Finch <dot@dotat.at> wrote: > On the repository summary page, leave the whole owner line out if > the repo does not have an owner, rather than displaying a labelled > empty field.. Note that if $omit_owner is true, whole _column_ is skipped. Is removing cell (instead of leaving it empty) and relying on browser treating nonexistent cell correctly a good idea, that I do not know. Does it looks better? Does it looks better in all web browsers? > Signed-off-by: Tony Finch <dot@dotat.at> > --- > gitweb/gitweb.perl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl > index 8d69ada..c029b98 100755 > --- a/gitweb/gitweb.perl > +++ b/gitweb/gitweb.perl > @@ -6463,7 +6463,7 @@ sub git_summary { > print "<div class=\"title\"> </div>\n"; > print "<table class=\"projects_list\">\n" . > "<tr id=\"metadata_desc\"><td>description</td><td>" . esc_html($descr) . "</td></tr>\n"; > - unless ($omit_owner) { > + if ($owner and not $omit_owner) { > print "<tr id=\"metadata_owner\"><td>owner</td><td>" . esc_html($owner) . "</td></tr>\n"; > } > if (defined $cd{'rfc2822'}) { > -- > 1.8.3.1.605.g85318f5 > -- Jakub Narebski ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 3/4] gitweb: omit the repository owner when it is unset 2013-08-03 21:40 ` [PATCH 3/4] gitweb: omit the repository owner when it is unset Jakub Narębski @ 2013-08-05 11:36 ` Tony Finch 2013-08-20 17:22 ` [PATCH v4 0/4] Four small gitweb tweaks Tony Finch 0 siblings, 1 reply; 20+ messages in thread From: Tony Finch @ 2013-08-05 11:36 UTC (permalink / raw) To: Jakub Narębski; +Cc: git, Jonathan Nieder [-- Attachment #1: Type: TEXT/PLAIN, Size: 903 bytes --] Jakub Narębski <jnareb@gmail.com> wrote: > On Tue, Jul 2, 2013 at 6:24 PM, Tony Finch <dot@dotat.at> wrote: > > > On the repository summary page, leave the whole owner line out if > > the repo does not have an owner, rather than displaying a labelled > > empty field.. > > Note that if $omit_owner is true, whole _column_ is skipped. There are two places where the owner is displayed: on the list of projects, and on each project's summary page. This change affects the summary page (where it removes a row, not a column) and it leaves the projects list alone. I'll make that clearer in the commit message (and fix the extraneous dot). Tony. -- f.anthony.n.finch <dot@dotat.at> http://dotat.at/ Forties, Cromarty: East, veering southeast, 4 or 5, occasionally 6 at first. Rough, becoming slight or moderate. Showers, rain at first. Moderate or good, occasionally poor at first. ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v4 0/4] Four small gitweb tweaks 2013-08-05 11:36 ` Tony Finch @ 2013-08-20 17:22 ` Tony Finch 2013-08-20 16:59 ` [PATCH v4 1/4] gitweb: Ensure OPML text fits inside its box Tony Finch ` (3 more replies) 0 siblings, 4 replies; 20+ messages in thread From: Tony Finch @ 2013-08-20 17:22 UTC (permalink / raw) To: git; +Cc: Jakub Narębski, Jonathan Nieder This is mostly just a repost to un-stall this topic. I have fixed the tab damage problem spotted by Jakub in the search help link patch, and I have improved the commit message for the repository owner patch. No other changes. Tony Finch (4): gitweb: Ensure OPML text fits inside its box. gitweb: vertically centre contents of page footer gitweb: omit the repository owner when it is unset gitweb: make search help link less ugly gitweb/gitweb.perl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 1.8.3.1.605.g85318f5 ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v4 1/4] gitweb: Ensure OPML text fits inside its box. 2013-08-20 17:22 ` [PATCH v4 0/4] Four small gitweb tweaks Tony Finch @ 2013-08-20 16:59 ` Tony Finch 2013-08-20 19:52 ` Junio C Hamano 2013-08-20 16:59 ` [PATCH v4 2/4] gitweb: vertically centre contents of page footer Tony Finch ` (2 subsequent siblings) 3 siblings, 1 reply; 20+ messages in thread From: Tony Finch @ 2013-08-20 16:59 UTC (permalink / raw) To: git; +Cc: Jakub Narębski, Jonathan Nieder The rss_logo CSS style has a fixed width which is too narrow for the string "OPML". Replace the fixed width with horizontal padding so the text fits with nice margins. Signed-off-by: Tony Finch <dot@dotat.at> --- gitweb/static/gitweb.css | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css index cb86d2d..a869be1 100644 --- a/gitweb/static/gitweb.css +++ b/gitweb/static/gitweb.css @@ -548,8 +548,7 @@ a.linenr { a.rss_logo { float: right; - padding: 3px 0px; - width: 35px; + padding: 3px 5px; line-height: 10px; border: 1px solid; border-color: #fcc7a5 #7d3302 #3e1a01 #ff954e; -- 1.8.3.1.605.g85318f5 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH v4 1/4] gitweb: Ensure OPML text fits inside its box. 2013-08-20 16:59 ` [PATCH v4 1/4] gitweb: Ensure OPML text fits inside its box Tony Finch @ 2013-08-20 19:52 ` Junio C Hamano 0 siblings, 0 replies; 20+ messages in thread From: Junio C Hamano @ 2013-08-20 19:52 UTC (permalink / raw) To: Tony Finch; +Cc: git, Jakub Narębski, Jonathan Nieder Tony Finch <dot@dotat.at> writes: > The rss_logo CSS style has a fixed width which is too narrow for > the string "OPML". Replace the fixed width with horizontal padding > so the text fits with nice margins. Makes sense to me (although I do not do css). > > Signed-off-by: Tony Finch <dot@dotat.at> > --- > gitweb/static/gitweb.css | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css > index cb86d2d..a869be1 100644 > --- a/gitweb/static/gitweb.css > +++ b/gitweb/static/gitweb.css > @@ -548,8 +548,7 @@ a.linenr { > > a.rss_logo { > float: right; > - padding: 3px 0px; > - width: 35px; > + padding: 3px 5px; > line-height: 10px; > border: 1px solid; > border-color: #fcc7a5 #7d3302 #3e1a01 #ff954e; ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v4 2/4] gitweb: vertically centre contents of page footer 2013-08-20 17:22 ` [PATCH v4 0/4] Four small gitweb tweaks Tony Finch 2013-08-20 16:59 ` [PATCH v4 1/4] gitweb: Ensure OPML text fits inside its box Tony Finch @ 2013-08-20 16:59 ` Tony Finch 2013-08-20 19:53 ` Junio C Hamano 2013-08-20 16:59 ` [PATCH v4 3/4] gitweb: omit the repository owner when it is unset Tony Finch 2013-08-20 16:59 ` [PATCH v4 4/4] gitweb: make search help link less ugly Tony Finch 3 siblings, 1 reply; 20+ messages in thread From: Tony Finch @ 2013-08-20 16:59 UTC (permalink / raw) To: git; +Cc: Jakub Narębski, Jonathan Nieder Signed-off-by: Tony Finch <dot@dotat.at> --- gitweb/static/gitweb.css | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css index a869be1..3b4d833 100644 --- a/gitweb/static/gitweb.css +++ b/gitweb/static/gitweb.css @@ -68,12 +68,13 @@ div.page_path { } div.page_footer { - height: 17px; + height: 22px; padding: 4px 8px; background-color: #d9d8d1; } div.page_footer_text { + line-height: 22px; float: left; color: #555555; font-style: italic; -- 1.8.3.1.605.g85318f5 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH v4 2/4] gitweb: vertically centre contents of page footer 2013-08-20 16:59 ` [PATCH v4 2/4] gitweb: vertically centre contents of page footer Tony Finch @ 2013-08-20 19:53 ` Junio C Hamano 2013-08-21 9:06 ` Tony Finch 0 siblings, 1 reply; 20+ messages in thread From: Junio C Hamano @ 2013-08-20 19:53 UTC (permalink / raw) To: Tony Finch; +Cc: git, Jakub Narębski, Jonathan Nieder Tony Finch <dot@dotat.at> writes: > Signed-off-by: Tony Finch <dot@dotat.at> > --- > gitweb/static/gitweb.css | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css > index a869be1..3b4d833 100644 > --- a/gitweb/static/gitweb.css > +++ b/gitweb/static/gitweb.css > @@ -68,12 +68,13 @@ div.page_path { > } > > div.page_footer { > - height: 17px; > + height: 22px; > padding: 4px 8px; > background-color: #d9d8d1; > } > > div.page_footer_text { > + line-height: 22px; > float: left; > color: #555555; > font-style: italic; Hmmm, is it a good idea to do "px" here, or are they ways to do relative to x-height or something to make sure the text fits? ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH v4 2/4] gitweb: vertically centre contents of page footer 2013-08-20 19:53 ` Junio C Hamano @ 2013-08-21 9:06 ` Tony Finch 0 siblings, 0 replies; 20+ messages in thread From: Tony Finch @ 2013-08-21 9:06 UTC (permalink / raw) To: Junio C Hamano; +Cc: git, Jakub Narębski, Jonathan Nieder, Tony Finch Junio C Hamano <gitster@pobox.com> wrote: > Tony Finch <dot@dotat.at> writes: > > > div.page_footer { > > - height: 17px; > > + height: 22px; > > padding: 4px 8px; > > background-color: #d9d8d1; > > } > > > > div.page_footer_text { > > + line-height: 22px; > > float: left; > > color: #555555; > > font-style: italic; > > Hmmm, is it a good idea to do "px" here, or are they ways to do > relative to x-height or something to make sure the text fits? Good question. I also don't know much about css. I basically followed the style that was already there, and found out about vertical centering using line-height by searching the web. I think font-size relative scaling would require a bigger overhaul. Tony. -- f.anthony.n.finch <dot@dotat.at> http://dotat.at/ Forties, Cromarty: East, veering southeast, 4 or 5, occasionally 6 at first. Rough, becoming slight or moderate. Showers, rain at first. Moderate or good, occasionally poor at first. ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH v4 3/4] gitweb: omit the repository owner when it is unset 2013-08-20 17:22 ` [PATCH v4 0/4] Four small gitweb tweaks Tony Finch 2013-08-20 16:59 ` [PATCH v4 1/4] gitweb: Ensure OPML text fits inside its box Tony Finch 2013-08-20 16:59 ` [PATCH v4 2/4] gitweb: vertically centre contents of page footer Tony Finch @ 2013-08-20 16:59 ` Tony Finch 2013-08-20 16:59 ` [PATCH v4 4/4] gitweb: make search help link less ugly Tony Finch 3 siblings, 0 replies; 20+ messages in thread From: Tony Finch @ 2013-08-20 16:59 UTC (permalink / raw) To: git; +Cc: Jakub Narębski, Jonathan Nieder On the repository summary page, leave the owner line out if the repo does not have an owner, rather than displaying a labelled empty field. This does not affect the owner column in the projects list page, which is present unless $omit_owner is true. Signed-off-by: Tony Finch <dot@dotat.at> --- gitweb/gitweb.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 8d69ada..c029b98 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -6463,7 +6463,7 @@ sub git_summary { print "<div class=\"title\"> </div>\n"; print "<table class=\"projects_list\">\n" . "<tr id=\"metadata_desc\"><td>description</td><td>" . esc_html($descr) . "</td></tr>\n"; - unless ($omit_owner) { + if ($owner and not $omit_owner) { print "<tr id=\"metadata_owner\"><td>owner</td><td>" . esc_html($owner) . "</td></tr>\n"; } if (defined $cd{'rfc2822'}) { -- 1.8.3.1.605.g85318f5 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH v4 4/4] gitweb: make search help link less ugly 2013-08-20 17:22 ` [PATCH v4 0/4] Four small gitweb tweaks Tony Finch ` (2 preceding siblings ...) 2013-08-20 16:59 ` [PATCH v4 3/4] gitweb: omit the repository owner when it is unset Tony Finch @ 2013-08-20 16:59 ` Tony Finch 3 siblings, 0 replies; 20+ messages in thread From: Tony Finch @ 2013-08-20 16:59 UTC (permalink / raw) To: git; +Cc: Jakub Narębski, Jonathan Nieder The search help link was a superscript question mark right next to a drop-down menu, which looks misaligned and is a cramped and awkward click target. Remove the superscript tags and add some spacing to fix these nits. Add a title attribute to provide an explanatory mouseover. Signed-off-by: Tony Finch <dot@dotat.at> --- gitweb/gitweb.perl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 8d69ada..59af7de 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -4030,8 +4030,8 @@ sub print_search_form { $cgi->input({-name=>"h", -value=>$search_hash, -type=>"hidden"}) . "\n" . $cgi->popup_menu(-name => 'st', -default => 'commit', -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) . - $cgi->sup($cgi->a({-href => href(action=>"search_help")}, "?")) . - " search:\n", + " " . $cgi->a({-href => href(action=>"search_help"), + -title => "search help" }, "?") . " search:\n", $cgi->textfield(-name => "s", -value => $searchtext, -override => 1) . "\n" . "<span title=\"Extended regular expression\">" . $cgi->checkbox(-name => 'sr', -value => 1, -label => 're', -- 1.8.3.1.605.g85318f5 ^ permalink raw reply related [flat|nested] 20+ messages in thread
end of thread, other threads:[~2013-08-21 9:06 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-09 16:43 [PATCH] gitweb: Ensure OPML text fits inside its box Tony Finch
2013-07-09 17:08 ` [PATCH] gitweb: vertically centre contents of page footer Tony Finch
2013-07-14 23:49 ` [PATCH] gitweb: Ensure OPML text fits inside its box Jonathan Nieder
2013-07-02 16:24 ` [PATCH 3/4] gitweb: omit the repository owner when it is unset Tony Finch
2013-07-09 16:43 ` [PATCH 1/4] gitweb: Ensure OPML text fits inside its box Tony Finch
2013-07-09 17:08 ` [PATCH 2/4] gitweb: vertically centre contents of page footer Tony Finch
2013-07-09 17:15 ` [PATCH 4/4] gitweb: make search help link less ugly Tony Finch
2013-07-15 9:15 ` [PATCH] gitweb: Ensure OPML text fits inside its box Tony Finch
[not found] ` <E1Uyeth-0003TF-Kx@hermes-2.csi.cam.ac.uk>
2013-08-03 21:37 ` [PATCH 4/4] gitweb: make search help link less ugly Jakub Narębski
2013-08-05 11:19 ` Tony Finch
[not found] ` <E1Uyete-0003Sv-OI@hermes-2.csi.cam.ac.uk>
2013-08-03 21:40 ` [PATCH 3/4] gitweb: omit the repository owner when it is unset Jakub Narębski
2013-08-05 11:36 ` Tony Finch
2013-08-20 17:22 ` [PATCH v4 0/4] Four small gitweb tweaks Tony Finch
2013-08-20 16:59 ` [PATCH v4 1/4] gitweb: Ensure OPML text fits inside its box Tony Finch
2013-08-20 19:52 ` Junio C Hamano
2013-08-20 16:59 ` [PATCH v4 2/4] gitweb: vertically centre contents of page footer Tony Finch
2013-08-20 19:53 ` Junio C Hamano
2013-08-21 9:06 ` Tony Finch
2013-08-20 16:59 ` [PATCH v4 3/4] gitweb: omit the repository owner when it is unset Tony Finch
2013-08-20 16:59 ` [PATCH v4 4/4] gitweb: make search help link less ugly Tony Finch
Code repositories for project(s) associated with this public inbox https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).