git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jiang Xin <worldhello.net@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>, Jiang Xin <worldhello.net@gmail.com>
Subject: [PATCH v13 00/15] interactive git-clean
Date: Wed, 22 May 2013 09:40:21 +0800	[thread overview]
Message-ID: <cover.1369186574.git.worldhello.net@gmail.com> (raw)
In-Reply-To: <7vhahwm5n6.fsf@alter.siamese.dyndns.org>

2013/5/22 Junio C Hamano <gitster@pobox.com>:
> Jiang Xin <worldhello.net@gmail.com> writes:
>
>> diff --git a/test-path-utils.c b/test-path-utils.c
>> index 0092cb..18267 100644
>> --- a/test-path-utils.c
>> +++ b/test-path-utils.c
>> @@ -1,6 +1,19 @@
>>  #include "cache.h"
>>  #include "string-list.h"
>>
>> +#define PARSE_ARGV_STRING(var, input) do { \
>> +     if (!strcmp(input, "<null>")) { \
>> +             var = NULL; \
>> +     } else if (!strcmp(input, "<empty>")) { \
>> +             var = ""; \
>> +     } else if (*input == '<' || *input == '(') { \
>> +             fprintf(stderr, "Bad value: %s\n", input); \
>> +             return 1; \
>> +     } else { \
>> +             var = input; \
>> +     } \
>> +} while (0)
>
> Yuck. Why does it have to be a macro like this?  I do not think
> "because we may return" justifies it.

Rewrite patch 01/15 for this, and only patch 01/15 and 02/15 need update.
Please review.

Jiang Xin (15):
  test: add test cases for relative_path
  path.c: refactor relative_path(), not only strip prefix
  quote.c: remove path_relative, use relative_path instead
  Refactor quote_path_relative, remove unused params
  Refactor write_name_quoted_relative, remove unused params
  git-clean: refactor git-clean into two phases
  git-clean: add support for -i/--interactive
  git-clean: show items of del_list in columns
  git-clean: add colors to interactive git-clean
  git-clean: use a git-add-interactive compatible UI
  git-clean: add filter by pattern interactive action
  git-clean: add select by numbers interactive action
  git-clean: add ask each interactive action
  git-clean: add documentation for interactive git-clean
  test: add t7301 for git-clean--interactive

 Documentation/config.txt     |  21 +-
 Documentation/git-clean.txt  |  71 +++-
 builtin/clean.c              | 778 +++++++++++++++++++++++++++++++++++++++++--
 builtin/grep.c               |   5 +-
 builtin/ls-files.c           |  16 +-
 cache.h                      |   2 +-
 path.c                       | 112 +++++--
 quote.c                      |  65 +---
 quote.h                      |   7 +-
 setup.c                      |   5 +-
 t/t0060-path-utils.sh        |  23 ++
 t/t7301-clean-interactive.sh | 439 ++++++++++++++++++++++++
 test-path-utils.c            |  27 ++
 wt-status.c                  |  17 +-
 14 files changed, 1437 insertions(+), 151 deletions(-)
 create mode 100755 t/t7301-clean-interactive.sh

-- 
1.8.3.rc3.368.g7c798dd

  reply	other threads:[~2013-05-22  1:41 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-17  9:20 [PATCH v11 00/15] *** Interactive git-clean *** Jiang Xin
2013-05-17  9:20 ` [PATCH v11 01/15] path.c: refactor relative_path(), not only strip prefix Jiang Xin
2013-05-17  9:20 ` [PATCH v11 02/15] test: test relative_path through test-path-utils Jiang Xin
2013-05-17  9:20 ` [PATCH v11 03/15] quote.c: remove path_relative, use relative_path instead Jiang Xin
2013-05-17  9:20 ` [PATCH v11 04/15] Refactor quote_path_relative, remove unused params Jiang Xin
2013-05-17  9:20 ` [PATCH v11 05/15] Refactor write_name_quoted_relative, " Jiang Xin
2013-05-17  9:20 ` [PATCH v11 06/15] git-clean: refactor git-clean into two phases Jiang Xin
2013-05-17  9:20 ` [PATCH v11 07/15] git-clean: add support for -i/--interactive Jiang Xin
2013-05-17  9:20 ` [PATCH v11 08/15] git-clean: show items of del_list in columns Jiang Xin
2013-05-17  9:20 ` [PATCH v11 09/15] git-clean: add colors to interactive git-clean Jiang Xin
2013-05-17  9:20 ` [PATCH v11 10/15] git-clean: use a git-add-interactive compatible UI Jiang Xin
2013-05-17  9:20 ` [PATCH v11 11/15] git-clean: add filter by pattern interactive action Jiang Xin
2013-05-17  9:20 ` [PATCH v11 12/15] git-clean: add select by numbers " Jiang Xin
2013-05-17  9:20 ` [PATCH v11 13/15] git-clean: add ask each " Jiang Xin
2013-05-17  9:20 ` [PATCH v11 14/15] git-clean: add documentation for interactive git-clean Jiang Xin
2013-05-17  9:20 ` [PATCH v11 15/15] test: add t7301 for git-clean--interactive Jiang Xin
2013-05-18  3:18 ` [PATCH v12 00/15] Interactive git-clean Jiang Xin
2013-05-20 22:48   ` Junio C Hamano
2013-05-18  3:18 ` [PATCH v12 01/15] test: add test cases for relative_path Jiang Xin
2013-05-21 20:37   ` Junio C Hamano
2013-05-22  1:40     ` Jiang Xin [this message]
2013-05-22  1:40     ` [PATCH v13 " Jiang Xin
2013-05-22  1:40     ` [PATCH v13 02/15] path.c: refactor relative_path(), not only strip prefix Jiang Xin
2013-05-22  8:06       ` Michael Haggerty
2013-05-22 16:23         ` Junio C Hamano
2013-05-26  0:21         ` Jiang Xin
2013-05-30  6:56           ` Jiang Xin
2013-05-22  1:40     ` [PATCH v13 03/15] quote.c: remove path_relative, use relative_path instead Jiang Xin
2013-05-22  1:40     ` [PATCH v13 04/15] Refactor quote_path_relative, remove unused params Jiang Xin
2013-05-22  1:40     ` [PATCH v13 05/15] Refactor write_name_quoted_relative, " Jiang Xin
2013-05-22  1:40     ` [PATCH v13 06/15] git-clean: refactor git-clean into two phases Jiang Xin
2013-05-22  1:40     ` [PATCH v13 07/15] git-clean: add support for -i/--interactive Jiang Xin
2013-05-22  1:40     ` [PATCH v13 08/15] git-clean: show items of del_list in columns Jiang Xin
2013-05-22  1:40     ` [PATCH v13 09/15] git-clean: add colors to interactive git-clean Jiang Xin
2013-05-22  1:40     ` [PATCH v13 10/15] git-clean: use a git-add-interactive compatible UI Jiang Xin
2013-05-22  1:40     ` [PATCH v13 11/15] git-clean: add filter by pattern interactive action Jiang Xin
2013-05-22  1:40     ` [PATCH v13 12/15] git-clean: add select by numbers " Jiang Xin
2013-05-22  1:40     ` [PATCH v13 13/15] git-clean: add ask each " Jiang Xin
2013-05-22  1:40     ` [PATCH v13 14/15] git-clean: add documentation for interactive git-clean Jiang Xin
2013-05-22  1:40     ` [PATCH v13 15/15] test: add t7301 for git-clean--interactive Jiang Xin
2013-05-18  3:18 ` [PATCH v12 02/15] path.c: refactor relative_path(), not only strip prefix Jiang Xin
2013-05-18  3:18 ` [PATCH v12 03/15] quote.c: remove path_relative, use relative_path instead Jiang Xin
2013-05-18  3:18 ` [PATCH v12 04/15] Refactor quote_path_relative, remove unused params Jiang Xin
2013-05-18  3:18 ` [PATCH v12 05/15] Refactor write_name_quoted_relative, " Jiang Xin
2013-05-18  3:18 ` [PATCH v12 06/15] git-clean: refactor git-clean into two phases Jiang Xin
2013-05-18  3:18 ` [PATCH v12 07/15] git-clean: add support for -i/--interactive Jiang Xin
2013-05-18  3:19 ` [PATCH v12 08/15] git-clean: show items of del_list in columns Jiang Xin
2013-05-18  3:19 ` [PATCH v12 09/15] git-clean: add colors to interactive git-clean Jiang Xin
2013-05-18  3:19 ` [PATCH v12 10/15] git-clean: use a git-add-interactive compatible UI Jiang Xin
2013-05-18  3:19 ` [PATCH v12 11/15] git-clean: add filter by pattern interactive action Jiang Xin
2013-05-18  3:19 ` [PATCH v12 12/15] git-clean: add select by numbers " Jiang Xin
2013-05-18  3:19 ` [PATCH v12 13/15] git-clean: add ask each " Jiang Xin
2013-05-18  3:19 ` [PATCH v12 14/15] git-clean: add documentation for interactive git-clean Jiang Xin
2013-05-18  3:19 ` [PATCH v12 15/15] test: add t7301 for git-clean--interactive Jiang Xin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1369186574.git.worldhello.net@gmail.com \
    --to=worldhello.net@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).