From: Thomas Rast <trast@student.ethz.ch>
To: <git@vger.kernel.org>
Subject: [PATCH 0/4] Another bundle fix: reading freed memory
Date: Thu, 1 Mar 2012 22:40:47 +0100 [thread overview]
Message-ID: <cover.1330637923.git.trast@student.ethz.ch> (raw)
This is about the fourth patch, the other three are just cleanups.
Valgrind caught me reading free()d memory after the recent change to a
strbuf in create_bundle. Luckily it's the only report I got.
I made a token effort to verify that nobody else is playing mind games
with the .name fields in struct object_array, but I'm rather tired so
it would be nice if someone could double-check. In any case bundle is
the only user of object_array_remove_duplicates.
Thomas Rast (4):
t5510: refactor bundle->pack conversion
t5510: fix indent with spaces
t5510: ensure we stay in the toplevel test dir
bundle: keep around names passed to add_pending_object()
bundle.c | 2 +-
t/t5510-fetch.sh | 57 +++++++++++++++++++++++++++++++++---------------------
2 files changed, 36 insertions(+), 23 deletions(-)
--
1.7.9.2.467.g7fee4
next reply other threads:[~2012-03-01 21:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 21:40 Thomas Rast [this message]
2012-03-01 21:40 ` [PATCH 1/4] t5510: refactor bundle->pack conversion Thomas Rast
2012-03-01 21:40 ` [PATCH 2/4] t5510: fix indent with spaces Thomas Rast
2012-03-01 21:40 ` [PATCH 3/4] t5510: ensure we stay in the toplevel test dir Thomas Rast
2012-03-01 21:57 ` Junio C Hamano
2012-03-01 22:09 ` Thomas Rast
2012-03-01 22:32 ` Junio C Hamano
2012-03-01 22:33 ` Junio C Hamano
2012-03-01 21:40 ` [PATCH 4/4] bundle: keep around names passed to add_pending_object() Thomas Rast
2012-03-01 22:05 ` Junio C Hamano
2012-03-01 22:22 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1330637923.git.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).