From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Elijah Newren" <newren@gmail.com>,
"Martin Ågren" <martin.agren@gmail.com>,
"Andrzej Hunt" <ajrhunt@google.com>, "Jeff King" <peff@peff.net>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH v2 0/7] leak tests: fix "test-tool" & other small leaks
Date: Thu, 7 Oct 2021 12:01:30 +0200 [thread overview]
Message-ID: <cover-v2-0.7-00000000000-20211007T100014Z-avarab@gmail.com> (raw)
In-Reply-To: <cover-0.7-00000000000-20211006T095426Z-avarab@gmail.com>
Like my just-submitted series to mark existing tests as passing[1]
under the test mode added in ab/sanitize-leak-ci, this marks more
tests as passing, but here we need to fix some small memory
leaks. This goes on top of ab/sanitize-leak-ci.
See v1[1] for a more detailed summary, the only update here is to some
bad commit message grammar/phrasing in v1.
1. https://lore.kernel.org/git/cover-0.7-00000000000-20211006T095426Z-avarab@gmail.com/
Ævar Arnfjörð Bjarmason (7):
tests: fix a memory leak in test-prio-queue.c
tests: fix a memory leak in test-parse-options.c
tests: fix a memory leak in test-oidtree.c
tests: fix test-oid-array leak, test in SANITIZE=leak
ls-files: fix a trivial dir_clear() leak
ls-files: add missing string_list_clear()
merge: add missing strbuf_release()
builtin/ls-files.c | 14 ++++++--------
builtin/merge.c | 2 ++
t/helper/test-oid-array.c | 4 ++++
t/helper/test-oidtree.c | 3 +++
t/helper/test-parse-options.c | 7 ++++++-
t/helper/test-prio-queue.c | 2 ++
t/t0009-prio-queue.sh | 2 ++
t/t0040-parse-options.sh | 1 +
t/t0064-oid-array.sh | 2 ++
t/t0069-oidtree.sh | 1 +
t/t3001-ls-files-others-exclude.sh | 5 +++--
t/t3005-ls-files-relative.sh | 1 +
t/t3020-ls-files-error-unmatch.sh | 2 ++
t/t3700-add.sh | 1 +
t/t7104-reset-hard.sh | 1 +
t/t7604-merge-custom-message.sh | 1 +
16 files changed, 38 insertions(+), 11 deletions(-)
Range-diff against v1:
1: 8806f9cb5e8 = 1: 37cdf0ee348 tests: fix a memory leak in test-prio-queue.c
2: c24e115aa49 ! 2: 53b0da60804 tests: fix a memory leak in test-parse-options.c
@@ Commit message
tests: fix a memory leak in test-parse-options.c
Fix a memory leak in t/helper/test-parse-options.c, we were not
- freeing the allocated "struct string_list" or its items. While I'm at
- it move the declaration of the "list" string_list the
- cmd__parse_options() function.
+ freeing the allocated "struct string_list" or its items. Let's move
+ the declaration of the "list" variable into the cmd__parse_options()
+ and release it at the end.
In c8ba1639165 (parse-options: add OPT_STRING_LIST helper, 2011-06-09)
the "list" variable was added, and later on in
3: a216297aba1 = 3: 33a4b9c7c68 tests: fix a memory leak in test-oidtree.c
4: 4aa2a70c67e = 4: b8ce8d7e972 tests: fix test-oid-array leak, test in SANITIZE=leak
5: 58b5bc67435 = 5: 73cf1018953 ls-files: fix a trivial dir_clear() leak
6: 34749645f74 = 6: fc10353c0c5 ls-files: add missing string_list_clear()
7: d7c94fa2851 = 7: 9942c084244 merge: add missing strbuf_release()
--
2.33.0.1446.g6af949f83bd
next prev parent reply other threads:[~2021-10-07 10:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 10:02 [PATCH 0/7] leak tests: fix "test-tool" & other small leaks Ævar Arnfjörð Bjarmason
2021-10-06 10:02 ` [PATCH 1/7] tests: fix a memory leak in test-prio-queue.c Ævar Arnfjörð Bjarmason
2021-10-06 10:02 ` [PATCH 2/7] tests: fix a memory leak in test-parse-options.c Ævar Arnfjörð Bjarmason
2021-10-06 16:37 ` Elijah Newren
2021-10-06 10:02 ` [PATCH 3/7] tests: fix a memory leak in test-oidtree.c Ævar Arnfjörð Bjarmason
2021-10-06 10:02 ` [PATCH 4/7] tests: fix test-oid-array leak, test in SANITIZE=leak Ævar Arnfjörð Bjarmason
2021-10-06 10:02 ` [PATCH 5/7] ls-files: fix a trivial dir_clear() leak Ævar Arnfjörð Bjarmason
2021-10-06 10:02 ` [PATCH 6/7] ls-files: add missing string_list_clear() Ævar Arnfjörð Bjarmason
2021-10-06 10:02 ` [PATCH 7/7] merge: add missing strbuf_release() Ævar Arnfjörð Bjarmason
2021-10-06 16:47 ` [PATCH 0/7] leak tests: fix "test-tool" & other small leaks Elijah Newren
2021-10-07 10:01 ` Ævar Arnfjörð Bjarmason [this message]
2021-10-07 10:01 ` [PATCH v2 1/7] tests: fix a memory leak in test-prio-queue.c Ævar Arnfjörð Bjarmason
2021-10-07 10:01 ` [PATCH v2 2/7] tests: fix a memory leak in test-parse-options.c Ævar Arnfjörð Bjarmason
2021-10-07 10:01 ` [PATCH v2 3/7] tests: fix a memory leak in test-oidtree.c Ævar Arnfjörð Bjarmason
2021-10-07 10:01 ` [PATCH v2 4/7] tests: fix test-oid-array leak, test in SANITIZE=leak Ævar Arnfjörð Bjarmason
2021-10-07 10:01 ` [PATCH v2 5/7] ls-files: fix a trivial dir_clear() leak Ævar Arnfjörð Bjarmason
2021-10-07 22:46 ` Junio C Hamano
2021-10-13 13:39 ` Ævar Arnfjörð Bjarmason
2021-10-13 19:01 ` Junio C Hamano
2021-10-14 0:15 ` Ævar Arnfjörð Bjarmason
2021-10-14 17:38 ` Junio C Hamano
2021-10-07 10:01 ` [PATCH v2 6/7] ls-files: add missing string_list_clear() Ævar Arnfjörð Bjarmason
2021-10-07 10:01 ` [PATCH v2 7/7] merge: add missing strbuf_release() Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover-v2-0.7-00000000000-20211007T100014Z-avarab@gmail.com \
--to=avarab@gmail.com \
--cc=ajrhunt@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.agren@gmail.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).