Re: revised: [PATCH] Color support added to git-add--interactive.

["Dan Zwell" <dzwell@gmail.com>]

On 10/16/07, Shawn O. Pearce <spearce@spearce.org> wrote:
> Dan Zwell <dzwell@gmail.com> wrote:
> > Adds color to the prompts and output of git-add--interactive.
>
> I'm probbaly going to publish this in `pu` tonight but I have some
> comments that I think need to be addressed before this graduates
> any further.
>
> First off, no Signed-off-by?  This is big enough that I refuse to
> put it in the main tree without one.  Second it would really have
> helped if the email was formatted with `git format-patch`.  Copying
> the message headers and body over for the commit message was less
> than fun.  I have better things to do with my time.

Sorry, that I didn't read the document on submitting patches before
this. I will make the other changes you mention and re-send this in
the proper formatting.

>
> > +color.interactive.<slot>::
> > +        Use customized color for add--interactive output. `<slot>`
>
> You probably should talk about `git add --interactive` as that
> is what the git-add documentation calls it.  Many end-users don't
> even know that `git add -i` is exec()'ing into another program to
> accomplish its task.  I fixed this up when I applied the patch.
>
> > +Note: these are not the same colors/attributes that the
> > +rest of git supports, but are specific to git-add--interactive.
>
> This is a problem in my opinion.  Why can't it match the same
> names that the C code recognizes?  What if we one day were to
> see git-add--interactive.perl converted to C?  How would we then
> reconcile the color handling at that point in time?
Makes sense. I am adding a bit of code to parse git color strings into
perl color strings (so the user can use the same color names as with
the rest of git). I know this is a small change, but I'm learning perl
as I go, and I have exams this week, so it will take at least a day or
two. I will fix the color issue, and send a properly formatted and
signed-off patch. (Yes, I do agree to the Developer's Certificate of
Origin wrt to this patch.)

Thanks for your patience,
Dan

>
> --
> Shawn.
>