git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "Zack Weinberg" <zack@owlfolio.org>
To: phillip.wood@dunelm.org.uk, git@vger.kernel.org
Subject: Re: [bug] git log --invert-grep --grep=[sufficiently complicated regex] prints nothing
Date: Thu, 24 Nov 2022 08:36:55 -0500	[thread overview]
Message-ID: <cfbd647e-0e66-4417-8c94-c8cac905a78a@app.fastmail.com> (raw)
In-Reply-To: <909b0770-2ac2-1a87-498b-0537a94e94ac@dunelm.org.uk>

On Thu, Nov 24, 2022, at 5:31 AM, Phillip Wood wrote:
> I think the problem is that you are excluding the commit that renames 
> the file and that stops --follow from following the rename. See below 
> for a simple reproduction using git's test suite.

Yes, I can confirm.  Both of the "incorrect output" examples I gave
involved excluding a commit that renames the file.  If I don't do that
there is no problem with an `a|b|c` regex.

> I'm afraid I'm not 
> familiar with the --follow code so I've no idea how to fix this.

I'm honestly unsure what the right behavior _should_ be, now.  I
expected --grep to be applied very late in the process, after the
set of commits touching the specified file had already been computed
(including all of its previous names, because of --follow) but the
documentation is ambiguous.

zw

  reply	other threads:[~2022-11-24 13:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23 20:17 [bug] git log --invert-grep --grep=[sufficiently complicated regex] prints nothing Zack Weinberg
2022-11-24 10:31 ` Phillip Wood
2022-11-24 13:36   ` Zack Weinberg [this message]
2022-11-24 15:53     ` Ævar Arnfjörð Bjarmason
2022-11-24 16:35       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfbd647e-0e66-4417-8c94-c8cac905a78a@app.fastmail.com \
    --to=zack@owlfolio.org \
    --cc=git@vger.kernel.org \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).