git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Ben Peart <peartben@gmail.com>
To: Lars Schneider <larsxschneider@gmail.com>,
	Git Mailing List <git@vger.kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Re: RFC: Would a config fetch.retryCount make sense?
Date: Thu, 1 Jun 2017 09:33:27 -0400	[thread overview]
Message-ID: <cf8ce12b-8d5a-ae03-efd8-0f82ea40fce7@gmail.com> (raw)
In-Reply-To: <6762A30E-C558-4085-943B-AB85EBF18706@gmail.com>



On 6/1/2017 8:48 AM, Lars Schneider wrote:
> Hi,
> 
> we occasionally see "The remote end hung up unexpectedly" (pkt-line.c:265)
> on our `git fetch` calls (most noticeably in our automations). I expect
> random network glitches to be the cause.
> 
> In some places we added a basic retry mechanism and I was wondering
> if this could be a useful feature for Git itself.
> 

Having a configurable retry mechanism makes sense especially if it 
allows continuing an in-progress download rather than aborting and 
trying over.  I would make it off by default so that any existing higher 
level retry mechanism doesn't trigger a retry storm if the problem isn't 
a transient network glitch.

Internally we use a tool 
(https://github.com/Microsoft/GVFS/tree/master/GVFS/FastFetch) to 
perform fetch for our build machines.  It has several advantages 
including retries when downloading pack files.

It's biggest advantage is that it uses multiple threads to parallelize 
the entire fetch and checkout operation from end to end (ie the download 
happens in parallel as well as checkout happening in parallel with the 
download) which makes it take a fraction of the overall time.

When time permits, I hope to bring some of these enhancements over into 
git itself.

> E.g. a Git config such as "fetch.retryCount" or something.
> Or is there something like this in Git already and I missed it?
> 
> Thanks,
> Lars
> 

  reply	other threads:[~2017-06-01 13:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-01 12:48 RFC: Would a config fetch.retryCount make sense? Lars Schneider
2017-06-01 13:33 ` Ben Peart [this message]
2017-06-05 12:04   ` Lars Schneider
2017-06-05 14:08     ` Ben Peart
2017-06-01 17:59 ` Stefan Beller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cf8ce12b-8d5a-ae03-efd8-0f82ea40fce7@gmail.com \
    --to=peartben@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=larsxschneider@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).