git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "René Scharfe" <l.s.r@web.de>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [ANNOUNCE] Git v2.29.0-rc1
Date: Sat, 10 Oct 2020 18:45:07 +0200	[thread overview]
Message-ID: <ce8f482f-9a78-6867-38ae-601bcc2c9f66@web.de> (raw)
In-Reply-To: <xmqq7drzv1bn.fsf@gitster.c.googlers.com>

Am 09.10.20 um 17:58 schrieb Junio C Hamano:
>  * "git archive" learns the "--add-file" option to include untracked
>    files into a snapshot from a tree-ish.

>       archive: read short blobs in archive.c::write_archive_entry()
>       archive: add --add-file
>       Makefile: use git-archive --add-file

Oh, this feature landed quickly, with little discussion.  I dropped the
ball while being distracted by other things and working on supporting
other use cases, like dist-doc and artifacts-tar.

The option --add-file in rc1 is peculiar in that it captures the value
of --prefix at the time of left-to-right parsing.  I don't know any
other option that does that.  It gives users a way to craft in-archive
paths, but simply adding them with their original path (just normalized
to use slashes as directory separators) would probably suffice.

The option serves a niche use case, so this weirdness might be bearable,
but I wouldn't have expected it to be merged without debate.  Perhaps
we want to slap an "experimental" label on it?

We can create the dist-doc tars easily without --add-file and tar(1);
patch forthcoming.

We could do the same for artifacts-tar, but that would generate a huge
archive due to the many hardlinks for dash aliases that are flattened
into copies.  Implementing hardlink support might be worthwhile anyway
and we would not even have to make it optional.  This target doesn't use
TAR_DIST_EXTRA_OPTS, so this is a separate topic anyway, though.

René

  reply	other threads:[~2020-10-10 23:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09 15:58 [ANNOUNCE] Git v2.29.0-rc1 Junio C Hamano
2020-10-10 16:45 ` René Scharfe [this message]
2020-10-11  6:11   ` René Scharfe
2020-10-12 16:35     ` Junio C Hamano
2020-10-12 16:33   ` Junio C Hamano
2020-10-12 19:19     ` René Scharfe
2020-10-24 17:52       ` René Scharfe
2020-10-26 18:01         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce8f482f-9a78-6867-38ae-601bcc2c9f66@web.de \
    --to=l.s.r@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).