From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Miriam Rubio <mirucam@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v4 2/6] t6030-bisect-porcelain: add test for bisect visualize
Date: Tue, 17 Aug 2021 16:03:14 +0700 [thread overview]
Message-ID: <cca9771b-035e-0aca-bcf2-115f7af364e4@gmail.com> (raw)
In-Reply-To: <20210817081458.53136-3-mirucam@gmail.com>
On 17/08/21 15.14, Miriam Rubio wrote:
> Add a test to control breakages in bisect visualize command.
>
> Signed-off-by: Miriam Rubio <mirucam@gmail.com>
> ---
> t/t6030-bisect-porcelain.sh | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh
> index f41453cc97..99b7517400 100755
> --- a/t/t6030-bisect-porcelain.sh
> +++ b/t/t6030-bisect-porcelain.sh
> @@ -976,4 +976,11 @@ test_expect_success 'bisect run fails with exit code smaller than 0' '
> test_must_fail git bisect run ./test_script.sh > my_bisect_log.txt
> '
>
> +test_expect_success 'bisect visualize with a filename with dash and space' '
> + echo "My test line" >> -hello\ 2 &&
> + git add -- -hello\ 2 &&
> + git commit --quiet -m "Add test line" -- -hello\ 2 &&
> + git bisect visualize -p -- -hello\ 2 > my_bisect_log.txt
> +'
> +
> test_done
>
Seems like you're testing with filename with dash and space. Does git
bisect visualize have any problems handling such filenames?
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2021-08-17 9:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 8:14 [PATCH v4 0/6]Finish converting git bisect to C part 4 Miriam Rubio
2021-08-17 8:14 ` [PATCH v4 1/6] t6030-bisect-porcelain: add tests to control bisect run exit cases Miriam Rubio
2021-08-17 9:00 ` Bagas Sanjaya
2021-08-17 9:23 ` Christian Couder
2021-08-17 20:19 ` Miriam R.
2021-08-17 8:14 ` [PATCH v4 2/6] t6030-bisect-porcelain: add test for bisect visualize Miriam Rubio
2021-08-17 9:03 ` Bagas Sanjaya [this message]
2021-08-17 20:17 ` Miriam R.
2021-08-17 8:14 ` [PATCH v4 3/6] run-command: make `exists_in_PATH()` non-static Miriam Rubio
2021-08-17 8:14 ` [PATCH v4 4/6] bisect--helper: reimplement `bisect_visualize()`shell function in C Miriam Rubio
2021-08-17 11:30 ` Johannes Schindelin
2021-08-17 20:19 ` Miriam R.
2021-08-17 8:14 ` [PATCH v4 5/6] bisect--helper: reimplement `bisect_run` shell " Miriam Rubio
2021-08-17 11:42 ` Johannes Schindelin
2021-08-17 20:22 ` Miriam R.
2021-08-17 21:36 ` Johannes Schindelin
2021-08-18 8:33 ` Christian Couder
2021-08-18 9:43 ` Miriam R.
2021-08-17 8:14 ` [PATCH v4 6/6] bisect--helper: retire `--bisect-next-check` subcommand Miriam Rubio
2021-08-17 11:57 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cca9771b-035e-0aca-bcf2-115f7af364e4@gmail.com \
--to=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=mirucam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).