From: Johannes Schindelin <johannes.schindelin@gmx.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Daniel Smith <dansmith65@gmail.com>,
git@vger.kernel.org, Paul Smith <paul@mad-scientist.net>,
Jeff King <peff@peff.net>,
Ralf Wildenhues <Ralf.Wildenhues@gmx.de>,
Richard Hartmann <richih@net.in.tum.de>
Subject: Re: [PATCH] git-new-workdir: add windows compatibility
Date: Tue, 26 May 2015 11:53:09 +0200 [thread overview]
Message-ID: <cbfbf842705637b52cde9c6b61f89a75@www.dscho.org> (raw)
In-Reply-To: <xmqqfv6k7zp3.fsf@gitster.dls.corp.google.com>
Hi,
On 2015-05-26 06:03, Junio C Hamano wrote:
> Daniel Smith <dansmith65@gmail.com> writes:
>
>> When running on Windows in MinGW, creating symbolic links via ln always
>> failed.
>>
>> Using mklink instead of ln is the recommended method of creating links on
>> Windows:
>> http://stackoverflow.com/questions/18641864/git-bash-shell-fails-to-create-symbolic-links
>>
>> Script now branches on Windows to use mklink. This change should not affect
>> unix systems.
>>
>> Signed-off-by: Daniel Smith <dansmith65@gmail.com>
>>
>> Has been tested on Windows 8.1 and OS X Yosemite.
>> ---
>
> Swap the "Has been tested..." and "Signed-off-by:" lines.
>
> I'll defer to Windows folks if "mklink" is a sensible thing to use
> or not; I have no first-hand experience with Windows, but only heard
> that links are for admin user only or something like that, so I want
> to hear from people whose judgement on Windows matters I trust.
The biggest problem with `mklink` is that it is only supported on Windows Vista and later, while I really like to keep Windows XP support in Git for Windows.
That is why Karsten Blees' symlink support (emulated via NTFS reparse points) which I just merged into Git for Windows yesterday is so careful about everything.
But git-new-workdir is in `contrib/`, anyway, and not installed in Git for Windows by default, therefore it is less critical: interested parties will have to be a bit knowledgeable in any case.
So I am fine with it!
Ciao,
Dscho
next prev parent reply other threads:[~2015-05-26 14:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CADBZQ5iAKsSrdvBnFcdPcm9psaJo5B-H1zqJj0aRc+xx6cCFMQ@mail.gmail.com>
2015-05-26 4:03 ` [PATCH] git-new-workdir: add windows compatibility Junio C Hamano
2015-05-26 9:53 ` Johannes Schindelin [this message]
2015-05-26 12:20 ` Paul Smith
2015-05-26 12:35 ` Johannes Schindelin
2015-05-29 9:53 ` Michael J Gruber
2015-05-29 10:48 ` Duy Nguyen
2015-05-29 10:52 ` Johannes Schindelin
2015-05-26 16:48 ` Karsten Blees
[not found] ` <CADBZQ5hR1L7FPM_Ht00-as5eXw+PMJk1T2P3_ZiHedf0bi-H1w@mail.gmail.com>
2015-05-27 8:17 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbfbf842705637b52cde9c6b61f89a75@www.dscho.org \
--to=johannes.schindelin@gmx.de \
--cc=Ralf.Wildenhues@gmx.de \
--cc=dansmith65@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=paul@mad-scientist.net \
--cc=peff@peff.net \
--cc=richih@net.in.tum.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).