git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Paul Smith <paul@mad-scientist.net>
To: Edua Vioz <eltipejoloco@gmail.com>, git@vger.kernel.org
Subject: Re: Questions about Git-Gui Makefile and GNU File Name and Text Functions
Date: Wed, 03 Jun 2020 10:34:06 -0400	[thread overview]
Message-ID: <c931a1a5bf041057fa75febf6c05b7435ce27881.camel@mad-scientist.net> (raw)
In-Reply-To: <CAGiZ90kHSZEjw2ApU4kyGqCCH0KJS2Fe1mbvkJy4W2YKXs_-=w@mail.gmail.com>

On Wed, 2020-06-03 at 02:56 -0500, Edua Vioz wrote:
> Would the outcome of $(dir C:/Program
> Files/Git/mingw64/libexec/git-core) be "C:/Program
> Files/Git/mingw64/libexec/" or "C:/ Files/Git/mingw64/libexec/"?

I'm not super-familiar with the Git build system so maybe there are
mitigations for this there but: GNU make always treats whitespace as a
word separator so it will apply the "dir" function to each word.  So:

  $(dir C:/Program Files/Git/mingw64/libexec/git-core)

is equivalent to writing:

  $(dir C:/Program) $(dir Files/Git/mingw64/libexec/git-core)

and the expected result is:

  C:/ Files/Git/mingw64/libexec

> If the latter, is there no way for the $(dir) File Name function to
> be told to respect white-spaces in files' directories?

No.  Make in general, and GNU make in particular, doesn't expect to be
given paths with whitespace in them.

Again I'm not an expert in the Git build system but my understanding is
that the install can be relocatable: in that case I recommend you build
it into a location where there is no whitespace in the path, then move
it wherever you like after building.

> Additionally, would $(notdir C:/Program
> Files/Git/mingw64/libexec/git-core) result in "Program git-core"?

Yes.  All GNU make functions work the same way.


  reply	other threads:[~2020-06-03 15:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03  7:56 Questions about Git-Gui Makefile and GNU File Name and Text Functions Edua Vioz
2020-06-03 14:34 ` Paul Smith [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-06-03 19:45 Edua Vioz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c931a1a5bf041057fa75febf6c05b7435ce27881.camel@mad-scientist.net \
    --to=paul@mad-scientist.net \
    --cc=eltipejoloco@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).