From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-5.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 50F7B1F670 for ; Mon, 25 Oct 2021 11:53:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231842AbhJYL4L (ORCPT ); Mon, 25 Oct 2021 07:56:11 -0400 Received: from bsmtp3.bon.at ([213.33.87.17]:52531 "EHLO bsmtp3.bon.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231835AbhJYL4K (ORCPT ); Mon, 25 Oct 2021 07:56:10 -0400 Received: from [192.168.0.98] (unknown [93.83.142.38]) by bsmtp3.bon.at (Postfix) with ESMTPSA id 4HdCyx3Bqkz5tl9; Mon, 25 Oct 2021 13:53:45 +0200 (CEST) Subject: Re: [PATCH v4 8/8] progress.c: add & assert a "global_progress" variable To: =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= Cc: Junio C Hamano , =?UTF-8?Q?SZEDER_G=c3=a1bor?= , =?UTF-8?Q?Ren=c3=a9_Scharfe?= , Emily Shaffer , Taylor Blau , git@vger.kernel.org References: From: Johannes Sixt Message-ID: Date: Mon, 25 Oct 2021 13:53:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Am 25.10.21 um 13:25 schrieb Ævar Arnfjörð Bjarmason: > Once we have a > global current progress object we'll be able to update that object via > SIGALRM, this will cover cases where we're busy, but either haven't > invoked our first display_progress() yet, or the time between > display_progress() is too long. See [3] for early code to do that. This can't be a goal. You cannot do serious stuff in a signal handler. Don't proliferate complicated signal handlers. On top of that, our SIGALRM handler on Windows runs in its own thread and can't do more than set a volatile sigatomic_t (and even that is undefined behavior, strictly speaking). -- Hannes