mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jon Simons <>
To: Eric Sunshine <>
Cc: Git List <>, Taylor Blau <>,
	Jeff King <>, Derrick Stolee <>
Subject: Re: [PATCH v2 1/2] list-objects-filter: only parse sparse OID when 'have_git_dir'
Date: Thu, 29 Aug 2019 17:24:37 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 8/29/19 4:48 PM, Eric Sunshine wrote:
> On Thu, Aug 29, 2019 at 7:12 PM Jon Simons <> wrote:
>> On 8/29/19 3:45 PM, Eric Sunshine wrote:
>>> On Thu, Aug 29, 2019 at 6:38 PM Jon Simons <> wrote:
>>>> +       test_write_lines /* >sparse-src/all-files &&
>>> Hmm, does this work correctly? I would expect the /* to expand to all
>>> names at the root of your filesystem, which isn't what you want. You
>>> want the literal string "/*", which means you should quote it (with
>>> double quotes inside the test body). [...]
>> Oof, thanks -- yes, this is incorrect.  I will revert this back to
>> 'echo'.  I misapplied your initial suggesttion to all three lines.
> Curious. Did the test still pass even with the unquoted "/*"? If so,
> does that indicate a flaw in the test or somewhere else?

Yes, the test also passes with the unquoted "/*".  I think this showcases
that the test really is a bare minimal sanity check that clones providing
a sparse filter argument are able to run to completion.  As-is the test
does not further assert any behavior of the filter, just that the BUG is


  reply	other threads:[~2019-08-30  0:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-29 22:38 [PATCH v2 0/2] partial-clone: fix two issues with sparse filter handling Jon Simons
2019-08-29 22:38 ` [PATCH v2 1/2] list-objects-filter: only parse sparse OID when 'have_git_dir' Jon Simons
2019-08-29 22:45   ` Eric Sunshine
2019-08-29 23:12     ` Jon Simons
2019-08-29 23:48       ` Eric Sunshine
2019-08-30  0:24         ` Jon Simons [this message]
2019-08-29 22:38 ` [PATCH v2 2/2] list-objects-filter: handle unresolved sparse filter OID Jon Simons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).